Update BlockItemPacketRewriter1_9.java#699
Open
Term4 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
1.21.2, servers can update a single player-inventory slot via ClientboundSetPlayerInventory. ViaBackwards maps that to CONTAINER_SET_SLOT with window id -2
The 1.8 client's handleSetSlot only handles window -1, 0, and the oopen container's id. No -2 case, so these updates are silently dropped. This leads to the inventory only resyncing on a full window refresh (when a player opens and closes their inventory). Any server that uses this packet for inventorry updates (AHEM Minestom, but also some edge cases in vanilla, or custom vanilla servers) have this issue.