Repository navigation
V17 fix upgrade blockers - #742
Merged
Merged
Conversation
… columns openupgradelib.delete_record_translations picks every field flagged translate in ir_model_fields and applies the jsonb operator ? to the column of that name. Such a column is not always jsonb: it can belong to a module not loaded yet, or be a column left behind by an older version. The account_edi 17.0 post-migration died that way on ir_cron.name, a varchar column from the time the name was stored on ir_cron (the field is now delegated to ir.actions.server): "operator does not exist: character varying ? unknown" (tvtma, upgrading from 16.0; 18 scripts call the helper). Restrict the call to the translated columns that are jsonb already. (cherry picked from commit a6f47d8)
…conversion type In '%(street2)' followed by a line break, the line break becomes the conversion type and formatting the address raises "unsupported format character". Odoo shipped that format for Japan in 11.0 (13ee559, fixed by 087bebf); countries are noupdate data, so databases that loaded it back then still have it. The end-migration of account_edi_ubl_cii writes on every partner with a country, which computes the partner's address, and the 16.0 -> 17.0 upgrade of tvtma died there on its two Japanese partners. Add the missing conversion type to such placeholders before anything reads the formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.