V17 v3tech upgrade

openupgrade_framework/odoo_patch/odoo/addons/base/models/ir_ui_view.py

@@ -5,6 +5,7 @@
 
 from odoo import api
 from odoo.exceptions import ValidationError
+from odoo.modules.module import get_resource_from_path
 from odoo.tools import mute_logger
 
 from odoo.addons.base.models.ir_ui_view import NameManager, View
@@ -85,6 +86,22 @@ def _check_field_paths(self, node, field_paths, model_name, use):
         pass
 
 
+def _inverse_arch(self):
+    """
+    Remove install_filename from context if it's from openupgrade_scripts.
+    Without this, arch_fs will point to openupgrade_scripts' file which most likely
+    won't exist when the migrated database is deployed, which breaks resetting views
+    """
+    if "install_filename" in self._context:
+        path_info = get_resource_from_path(self._context["install_filename"])
+        if path_info and path_info[0] == "openupgrade_scripts":
+            # Needs to override the context to remove the install_filename
+            self = self.with_context(  # pylint: disable=context-overridden
+                {k: v for k, v in self._context.items() if k != "install_filename"}
+            )
+    return _inverse_arch._original_method(self)
+
+
 _check_xml._original_method = View._check_xml
 View._check_xml = _check_xml
 check._original_method = NameManager.check
@@ -93,3 +110,28 @@ def _check_field_paths(self, node, field_paths, model_name, use):
 View._raise_view_error = _raise_view_error
 _check_field_paths._original_method = View._check_field_paths
 View._check_field_paths = _check_field_paths
+_inverse_arch._original_method = View._inverse_arch
+View._inverse_arch = _inverse_arch
+
+
+def unlink(self):
+    """Remove the archived children of a view deleted with its module too.
+
+    The cascade of the core (under the module uninstall flag, which the end of
+    an update sets) goes through inherit_children_ids, which leaves out the
+    archived views (e.g. an option of the website editor turned off): their
+    foreign key then keeps the parent from being deleted, and the log shows
+    'violates foreign key constraint ir_ui_view_inherit_id_fkey'.
+    """
+    if self.env.context.get("_force_unlink"):
+        archived = (
+            self.with_context(active_test=False).inherit_children_ids
+            - self.inherit_children_ids
+        )
+        if archived:
+            archived.unlink()
+    return unlink._original_method(self)
+
+
+unlink._original_method = View.unlink
+View.unlink = unlink

openupgrade_framework/odoo_patch/odoo/models.py

@@ -19,16 +19,26 @@ def unlink(self):
     """
     if not self.env.context.get(MODULE_UNINSTALL_FLAG):
         return BaseModel.unlink._original_method(self)
-    savepoint = str(uuid4)
+    savepoint = str(uuid4())
     try:
         self.env.cr.execute(  # pylint: disable=sql-injection
             'SAVEPOINT "%s"' % savepoint
         )
-        return BaseModel.unlink._original_method(self)
+        result = BaseModel.unlink._original_method(self)
+        # release it: a savepoint left open per deleted record keeps a
+        # transactionid lock until the end of the update, enough to exhaust
+        # the lock table of the cluster on a large update
+        self.env.cr.execute(  # pylint: disable=sql-injection
+            'RELEASE SAVEPOINT "%s"' % savepoint
+        )
+        return result
     except Exception as e:
         self.env.cr.execute(  # pylint: disable=sql-injection
             'ROLLBACK TO SAVEPOINT "%s"' % savepoint
         )
+        self.env.cr.execute(  # pylint: disable=sql-injection
+            'RELEASE SAVEPOINT "%s"' % savepoint
+        )
         _logger.warning(
             "Could not delete obsolete record with ids %s of model %s: %s",
             self.ids,

openupgrade_scripts/apriori.py

@@ -11,6 +11,10 @@
     # odoo/enterprise
     # OCA/delivery-carrier
     "delivery_carrier_customer_info": "partner_delivery_info",
+    # OCA/l10n-spain
+    "l10n_es_pos": "l10n_es_pos_oca",
+    # OCA/server-tools
+    "mail_template_attachment_i18n": "mail_template_attachment_per_lang",
     # OCA/social
     "mail_activity_unlink_log": "mail_activity_cancel_tracking",
     # Viindoo/tvtmaaddons
@@ -56,6 +60,8 @@
     "website_sale_digital": "website_sale",
     "website_sale_loyalty_delivery": "website_sale_loyalty",
     "website_sale_stock_product_configurator": "website_sale_product_configurator",
+    # OCA/account-financial-tools
+    "base_vat_optional_vies": "base_vat",
     # OCA/account-invoicing
     "account_invoice_fiscal_position_update": "account",
     # OCA/e-commerce
@@ -78,6 +84,8 @@
     # OCA/product-attribute
     "product_catalog": "product",
     "product_catalog_sale": "sale",
+    # OCA/project
+    "project_list": "project",
     # OCA/purchase-workflow
     "purchase_discount": "purchase",
     # OCA/sale-promotion
@@ -88,6 +96,7 @@
     # OCA/social
     "mail_activity_plan": "mail",
     "mass_mailing_custom_unsubscribe_event": "mass_mailing",
+    "mail_template_multi_attachment": "mail",
     # OCA/stock-logistics-warehouse
     "stock_lot_filter_available": "stock",
     # OCA/web
@@ -105,9 +114,10 @@
     "to_hr_payroll_patch1": "to_hr_payroll",
     "to_hr_timesheet_payroll_patch1": "to_hr_timesheet_payroll",
     "to_location_warehouse": "viin_stock",
-    "to_mail_notif_and_email": "mail",
     "to_sale_loyalty_patch_1": "viin_loyalty",
     "to_stock_report_common": "viin_stock",
+    # removed from 17.0 (35c195ede0) without successor
+    "to_uom_subscription": "uom",
     "to_vietnam_bank_icons": "payment",
     "to_vietnamese_number2words": "base",
     "to_website_recaptcha": "google_recaptcha",
@@ -207,3 +217,13 @@
     "repair.line": "stock.move",
     # OCA/...
 }
+
+# Modules of merged_modules that are not merged into anything: they are
+# removed without a successor on our addons paths. The technical records they
+# own (record rules, scheduled and server actions, views, menus, mail
+# templates...) are deleted by the update even when they are noupdate, and the
+# xml ids of records of models that go with them are detached: see
+# release_records_of_lost_modules in the pre-migration of base.
+lost_modules = [
+    "to_uom_subscription",
+]

openupgrade_scripts/scripts/account/17.0.1.2/post-migration.py

@@ -117,6 +117,7 @@ def _am_update_invoice_pdf_report_file(env):
             res_id = am.id
         FROM account_move am
         WHERE am.message_main_attachment_id = ia.id
+        AND am.move_type IN ('out_invoice', 'out_refund')
         """,
     )
 

openupgrade_scripts/scripts/account_debit_note/17.0.1.0/upgrade_analysis_work.txt

@@ -0,0 +1,5 @@
+---Models in module 'account_debit_note'---
+---Fields in module 'account_debit_note'---
+---XML records in module 'account_debit_note'---
+NEW ir.actions.server: account_debit_note.action_move_debit_note
+# NOTHING TO DO: New feature

openupgrade_scripts/scripts/account_fleet/17.0.1.0/upgrade_analysis_work.txt

@@ -0,0 +1,5 @@
+---Models in module 'account_fleet'---
+---Fields in module 'account_fleet'---
+---XML records in module 'account_fleet'---
+---nothing has changed in this module--
+# NOTHING TO DO

openupgrade_scripts/scripts/auth_ldap/17.0.1.0/upgrade_analysis_work.txt

@@ -0,0 +1,4 @@
+---Models in module 'auth_ldap'---
+---Fields in module 'auth_ldap'---
+---XML records in module 'auth_ldap'---
+---nothing has changed in this module--

openupgrade_scripts/scripts/base/17.0.1.3/pre-migration.py

@@ -56,6 +56,32 @@
 }
 
 
+def _handle_l10n_de_mis_reports_xmlids(cr):
+    """Before executing the merged modules, we need to rename some XML-IDs with the same
+    name of l10n_de_skr03_mis_reports/l10n_de_skr04_mis_reports into
+    l10n_de_mis_reports.
+    """
+    if not openupgrade.is_module_installed(
+        cr, "l10n_de_skr03_mis_reports"
+    ) and not openupgrade.is_module_installed(cr, "l10n_de_skr04_mis_reports"):
+        return
+    _xmlids_renames = []
+    # fmt: off
+    bs_names = ["anlagevermoegen", "immaterielle", "schutzrechte", "konzessionen", "firmenwert", "geleistetet_anzahlungen", "total_immaterielle", "grundstueck", "maschinen", "ausstattung", "anlagen_im_bau", "total_sachanlagen", "anteile", "ausleihungen", "beteiligungen", "ausleihungen_beteiligung", "wertpapiere_av", "sonstige_ausleihungen", "total_finanzanlagen", "total_anlagevermoegen", "umlaufvermoegen", "i_vorraete", "roh_hilfs_betriebsstoffe", "unfertige_leistungen", "fertige_erzeugnisse", "anzahlungen", "total_vorraete", "ii_forderungen", "forderungen_ll", "forderungen_unternehmen", "forderungen_beteiligungen", "total_forderungen", "iii_wertpapiere", "wertpapiere_uv_anteile", "wertpapiere_uv_sonstige", "total_wertpapiere_uv", "liquide_mittel", "total_umlaufvermoegen", "rechnungsabgrenzung_aktiva", "aktive_latente_steuern", "fehlbetrag", "aktivseite", "eigenkapital", "gezeichnetes_kapital", "variables_kapital", "gewinnruecklage", "ruecklage_gesetzlich", "ruecklage_eigene_anteile", "ruecklage_satzung", "ruecklage_andere_gewinne", "gewinn_des_jahres", "total_gewinnruecklage", "gewinn_verlustvortrag", "jahresgewinn_verlust", "sopo_mit_ruecklage", "total_eigenkapital", "rueckstellungen", "rueckstellungen_pensionen", "rueckstellungen_steuern", "rueckstellungen_sonstige", "total_rueckstellungen", "verbindlichkeiten", "verbindlichkeiten_anleihen", "verbindlichkeiten_bank", "verbindlichkeiten_ll", "verbindlichkeiten_wechsel", "verbindlichkeiten_sonstige", "total_verbindlichkeiten", "rechnungsabgrenzung_passiva", "passive_latente_steuern", "passivseite"]  # noqa: E501
+    pl_names = ["betriebliche_erloese", "umsatzerloese", "bestandsveraenderungen", "eigenleistungen", "sonstige_ertraege", "total_erloese", "betriebsaufwand", "materialaufwand", "materialaufwand_a", "materialaufwand_b", "personalaufwand", "personalaufwand_a", "personalaufwand_b", "abschreibungen", "abschreibungen_a", "abschreibungen_b", "sonstige_aufwendungen", "total_aufwendungen", "total_betriebsergebnis", "ertraege_beteiligungen", "ertraege_wertpapiere", "zinsertraege", "zinsaufwendungen", "ergebnis_gewoehnliche", "ao_ergebnis", "ao_ergebnis_erloese", "ao_ergebnis_aufwendungen", "total_ao_ergebnis", "steuern", "steuern_ertrag", "sonstige_steuern", "gewinn_verlust", "gewinnvortrag_vj", "entnahme_kapitalruecklage", "entnahme_gewinnruecklage", "einstellung_ruecklage", "bilanzgewinn"]  # noqa: E501
+    # fmt: on
+    for coa in ("skr03", "skr04"):
+        for report in ("mis_report_bs", "mis_report_pl"):
+            for name in [""] + bs_names + pl_names:
+                _xmlids_renames.append(
+                    (
+                        f"l10n_de_{coa}_mis_reports.{report}{'_' if name else ''}{name}",  # noqa: E501
+                        f"l10n_de_mis_reports.{report}_{coa}{'_' if name else ''}{name}",  # noqa: E501
+                    )
+                )
+    openupgrade.rename_xmlids(cr, _xmlids_renames)
+
+
 def _fill_ir_server_object_lines_into_action_server(cr):
     openupgrade.logged_query(
         cr,
@@ -225,10 +251,16 @@ def _handle_partner_private_type(cr):
         AND name IN %s
         AND translate = TRUE
         """,
-        (tuple(private_fields),),
+        (tuple(private_fields + ["name"]),),
     )
     translated_fields = [field[0] for field in cr.fetchall()]
 
+    # name of private contact may be null, which is forbidden by res_partner_check_name
+    if "name" in translated_fields:
+        query += ", name = COALESCE(name, jsonb_build_object('en_US', '*****'))"
+    else:
+        query += ", name = COALESCE(name, '*****')"
+
     for field in private_fields:
         # For non-translated fields, replace all values with '*****'
         if field not in translated_fields:
@@ -369,6 +401,64 @@ def _reset_stale_noupdate(cr):
             )
 
 
+_TECHNICAL_MODELS = (
+    "ir.actions.act_url",
+    "ir.actions.act_window",
+    "ir.actions.client",
+    "ir.actions.report",
+    "ir.actions.server",
+    "ir.actions.todo",
+    "ir.cron",
+    "ir.filters",
+    "ir.model.access",
+    "ir.property",
+    "ir.rule",
+    "ir.ui.menu",
+    "ir.ui.view",
+    "mail.template",
+    "website.menu",
+)
+
+
+def release_records_of_lost_modules(cr):
+    """A module that is removed without a successor is merged into the module
+    it extended (apriori.lost_modules), and the update of that module deletes
+    the records it no longer finds in the data files, except the noupdate
+    ones: release the technical records, so that they are deleted too, and
+    detach the xml ids of the records of models that go with the module (the
+    rows stay). Business records stay.
+    """
+    from odoo.addons.openupgrade_scripts import apriori as _apriori
+
+    lost_modules = tuple(getattr(_apriori, "lost_modules", []))
+    if not lost_modules:
+        return
+    openupgrade.logged_query(
+        cr,
+        """
+        UPDATE ir_model_data SET noupdate = FALSE
+        WHERE noupdate AND module IN %s AND model IN %s
+        """,
+        (lost_modules, _TECHNICAL_MODELS),
+    )
+    openupgrade.logged_query(
+        cr,
+        """
+        DELETE FROM ir_model_data d
+        WHERE d.module IN %s AND d.model IN (
+            SELECT m.model
+            FROM ir_model m
+            JOIN ir_model_data md ON md.model = 'ir.model'
+                AND md.res_id = m.id AND md.module IN %s
+            WHERE NOT EXISTS (
+                SELECT 1 FROM ir_model_data o
+                WHERE o.model = 'ir.model' AND o.res_id = m.id
+                    AND o.module NOT IN %s))
+        """,
+        (lost_modules,) * 3,
+    )
+
+
 @openupgrade.migrate(use_env=False)
 def migrate(cr, version):
     """
@@ -382,8 +472,15 @@ def migrate(cr, version):
             "recommended to run the Odoo with --load=openupgrade_framework "
             "when migrating your database."
         )
-    openupgrade.update_module_names(cr, renamed_modules.items())
-    openupgrade.update_module_names(cr, merged_modules.items(), merge_modules=True)
+    release_records_of_lost_modules(cr)
+    openupgrade.update_module_names(
+        cr, renamed_modules.items(), environment_namespec=True
+    )
+
+    _handle_l10n_de_mis_reports_xmlids(cr)
+    openupgrade.update_module_names(
+        cr, merged_modules.items(), merge_modules=True, environment_namespec=True
+    )
     openupgrade.clean_transient_models(cr)
     openupgrade.rename_xmlids(cr, _xmlids_renames)
     openupgrade.copy_columns(cr, _column_copies)

openupgrade_scripts/scripts/base_vat/17.0.1.0/post-migration.py

@@ -34,7 +34,8 @@ def _partner_fill_vies_valid(env):
                     ) IN (SELECT code FROM eu_countries)
                 ) THEN TRUE
             ELSE FALSE
-        END;
+        END
+        WHERE vies_valid IS NULL;
         """,
     )
 

openupgrade_scripts/scripts/base_vat/17.0.1.0/pre-migration.py

@@ -4,6 +4,20 @@
 
 
 def _partner_create_vies_valid_column(env):
+    if openupgrade.column_exists(env.cr, "res_partner", "vies_passed"):
+        # coming from base_vat_optional_vies module
+        openupgrade.rename_fields(
+            env,
+            [
+                (
+                    "res.partner",
+                    "res_partner",
+                    "vies_passed",
+                    "vies_valid",
+                ),
+            ],
+        )
+        return
     openupgrade.logged_query(
         env.cr,
         """