Repository navigation
feat(VCST-4933): add Shared Components to menu in page builder shell - #194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Test/page-object updates only; no production or auth logic changed in this diff.
Overview
Adds
Menu.SHARED_COMPONENTS("SharedComponents") to the page builder page-object constants so E2E tests can target the new Shared Components shell menu entry (aligned with VCST-4933 / the shell menu change).The page builder smoke test no longer asserts an exact sidebar
route_idslist (Draft, Pending, Active, etc.); that step and the unusedMenuimport were removed so adding menu items does not break smoke. Grid column and details-blade checks are unchanged.Reviewed by Cursor Bugbot for commit 53d0c7b. Bugbot is set up for automated code reviews on this repo. Configure here.