Repository navigation
Feat/node group members - #212
Merged
Merged
Conversation
Group membership could only be changed from the Nodes page, one group
per action, and the Node Groups page offered no way to see, add or
remove member nodes.
Node Groups page:
- "Add nodes..." row action: searchable multi-select of the nodes that
are not members yet, with their status and current groups
- "Manage members" row action: member list with per-row and bulk
remove, both type-to-confirm
- the Nodes count links to the node list filtered by the group
Nodes page:
- "Change groups" replaces "Add to group" and "Remove from group": one
dialog with every group as a checkbox, pre-checked from the current
membership. For several nodes a partially shared group starts in the
mixed state and only the groups that were changed are applied
- load the node groups on mount, so the Group filter and a ?group=
link show group names instead of "Unknown group"
- keep the details panel in step with the list after a reload
API:
- POST /api/v1/node-groups/{id}/nodes adds up to 5
atomic call, DELETE /api/v1/node-groups/{id}/nodes/{node_id} removes
one member. Both use the node:create / node:dele
per-node endpoints and are audited
- GET /api/v1/nodes accepts exclude_group to leave
a group
Docs: group-side procedure in the node groups guide, cross-linked from
the nodes guide.
Closes #210
Signed-off-by: Blagovest Petrov <blagovest@petrovs.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.