Repository navigation
test(agent): wait for the client to drop the old connection on server… - #218
Merged
Merged
Conversation
… restart TestClient_FollowsCAReplacement restarts the policy server on the same address several times. A heartbeat sent before the client noticed the previous server was gone went out on the dead connection and failed with "Unavailable: error reading from server: EOF", which made the test flaky in CI. Wait for the connection to leave READY after each restart so the next heartbeat dials the new server. This also makes the final negative checks fail on the TLS verification rather than on a stale connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… restart
TestClient_FollowsCAReplacement restarts the policy server on the same address several times. A heartbeat sent before the client noticed the previous server was gone went out on the dead connection and failed with "Unavailable: error reading from server: EOF", which made the test flaky in CI.
Wait for the connection to leave READY after each restart so the next heartbeat dials the new server. This also makes the final negative checks fail on the TLS verification rather than on a stale connection.