Skip to content

Add an impact gate and labels for review findings - #52

Merged
joshschmelzle merged 2 commits into
mainfrom
docs/review-impact-threshold
Oct 29, 2026
Merged

joshschmelzle merged 2 commits into
mainfrom
docs/review-impact-threshold

Conversation

@joshschmelzle

@joshschmelzle joshschmelzle commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Summary

Adds an impact gate for review findings. A reviewer reports a finding only with a concrete user scenario, or for data loss, a security hole, or a crash, and labels it Blocker, Follow-up, or Drop.

Testing

Documentation only. No code or CI behavior changes.


Note

Low Risk
Documentation-only guidance in AGENTS.md; no code, CI, or runtime behavior changes.

Overview
Updates agent guidance in agents/AGENTS.md so builders and reviewers stay aligned on scope and noise.

Under How to work, adds a rule to avoid designing for rare or hypothetical futures that were not requested.

Adds a Reviewing section (for agent reviewers, QA, and the existing self-review step). Findings must start with a concrete user scenario or qualify as data loss, security, or crash risk; otherwise they are dropped. Each reported finding gets a single label: Blocker, Follow-up, or Drop, with an explicit floor for serious bugs. Style, naming, docs-only nits, and unrequested edge cases are out of scope; empty reviews are OK.

Reviewed by Cursor Bugbot for commit 315792a. Bugbot is set up for automated code reviews on this repo. Configure here.

@joshschmelzle joshschmelzle added the documentation Improvements or additions to documentation label Oct 29, 2026
@joshschmelzle joshschmelzle self-assigned this Oct 29, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot completed successfully with no findings that need human review, and no approval policy requires extra review on this documentation change.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@joshschmelzle joshschmelzle changed the title Add customer-impact threshold for review findings Add an impact gate and labels for review findings Oct 29, 2026
@joshschmelzle
joshschmelzle merged commit ef0c10d into main Oct 29, 2026
7 checks passed
@joshschmelzle
joshschmelzle deleted the docs/review-impact-threshold branch October 29, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant