Repository navigation
Add an impact gate and labels for review findings - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Adds an impact gate for review findings. A reviewer reports a finding only with a concrete user scenario, or for data loss, a security hole, or a crash, and labels it Blocker, Follow-up, or Drop.
Testing
Documentation only. No code or CI behavior changes.
Note
Low Risk
Documentation-only guidance in AGENTS.md; no code, CI, or runtime behavior changes.
Overview
Updates agent guidance in
agents/AGENTS.mdso builders and reviewers stay aligned on scope and noise.Under How to work, adds a rule to avoid designing for rare or hypothetical futures that were not requested.
Adds a Reviewing section (for agent reviewers, QA, and the existing self-review step). Findings must start with a concrete user scenario or qualify as data loss, security, or crash risk; otherwise they are dropped. Each reported finding gets a single label: Blocker, Follow-up, or Drop, with an explicit floor for serious bugs. Style, naming, docs-only nits, and unrequested edge cases are out of scope; empty reviews are OK.
Reviewed by Cursor Bugbot for commit 315792a. Bugbot is set up for automated code reviews on this repo. Configure here.