Skip to content

Add diagnostics session recorder - #19

Open
Hamnah228 wants to merge 1 commit into
mainfrom
feature/diagnostics-recorder-hamnah
Open

Add diagnostics session recorder#19
Hamnah228 wants to merge 1 commit into
mainfrom
feature/diagnostics-recorder-hamnah

Conversation

@Hamnah228

Copy link
Copy Markdown

Summary

  • Add an installed diagnostics recorder command using rosbag2.
  • Record /diagnostics with duration, topic, output directory, and mock/live label options.
  • Write session metadata and protect existing output directories.
  • Add failure, shutdown, and real rosbag2 round-trip tests.
  • Document inspection and isolated-domain replay.
  • Ignore generated bag files.

Validation

  • colcon build --symlink-install
  • ROS_DOMAIN_ID=42 colcon test --event-handlers console_direct+
  • colcon test-result --all --verbose
  • Result: 49 tests, 0 errors, 0 failures, 0 skipped.
  • Timed and Ctrl+C recordings reopened successfully with ros2 bag info.
  • Mock recording replayed without the temporary publisher.

Evidence

A separate mock recording was shared with Malik:

waybionic-diagnostics-recorder-pr-mock.tar.gz

The recording is intentionally not committed to Git.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4940c6d2-92cf-4258-8d5d-c4cd7c90fbe6


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yassinsolim yassinsolim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 0a2e9e5. No blocking finding. Strict dependency installation/checking and all six recorder tests pass in an isolated Jazzy container, including a real rosbag recording/readback that preserves the diagnostic timestamp, level, message, and key/value data. I checked topic selection, existing-directory protection, metadata, and timed shutdown. This was mock-publisher validation, not a physical-hardware session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants