Add diagnostics session recorder - #19
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yassinsolim
left a comment
There was a problem hiding this comment.
Reviewed 0a2e9e5. No blocking finding. Strict dependency installation/checking and all six recorder tests pass in an isolated Jazzy container, including a real rosbag recording/readback that preserves the diagnostic timestamp, level, message, and key/value data. I checked topic selection, existing-directory protection, metadata, and timed shutdown. This was mock-publisher validation, not a physical-hardware session.
Summary
/diagnosticswith duration, topic, output directory, and mock/live label options.Validation
colcon build --symlink-installROS_DOMAIN_ID=42 colcon test --event-handlers console_direct+colcon test-result --all --verboseros2 bag info.Evidence
A separate mock recording was shared with Malik:
waybionic-diagnostics-recorder-pr-mock.tar.gzThe recording is intentionally not committed to Git.