ci: add -y to apt-get commands and unify cross-build install - #2717
Merged
Merged
Conversation
sbc100
reviewed
Mar 15, 2026
Contributor
Author
|
Yep! They changed the default to be more efficient.
…On Sun, Mar 15, 2026, 10:16 Sam Clegg ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/build.yml
<#2717 (comment)>:
> with:
python-version: '3.x'
- - uses: ***@***.***
+ - uses: ***@***.***
+ with:
+ fetch-depth: 0
Ah yes, of course, this is only the lint step, that makes sense.
Why did the v1 version not need this? Did it fetch all the history by
default maybe?
—
Reply to this email directly, view it on GitHub
<#2717 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEFCWAMYJLCBYY6C2SM2T4Q3QN3AVCNFSM6AAAAACWSDMTS6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSNJQGQYTANRUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
kevmoo
force-pushed
the
build_cleanup
branch
from
September 6, 2026 18:06
db3f22e to
43008e1
Compare
kevmoo
force-pushed
the
build_cleanup
branch
from
September 6, 2026 19:04
43008e1 to
cfe2ff5
Compare
kevmoo
changed the title
Contributor
Author
|
PTAL! |
sbc100
approved these changes
Sep 14, 2026
sbc100
left a comment
sbc100
left a comment
Member
There was a problem hiding this comment.
lgtm, but it looks like there are conflicts so maybe we need another merge or rebase?
kevmoo
changed the title
Contributor
Author
|
Merged |
sbc100
approved these changes
Sep 14, 2026
sbc100
pushed a commit
that referenced
this pull request
Sep 15, 2026
#2846) - Remove the unused `choco install ninja` step on `windows-latest` (added in `a08df5c9` but never used since Windows CMake defaults to Visual Studio). - Modernize CMake configuration across all platforms by using `-S . -B out` instead of manually creating `out/` and setting `working-directory: out`. Split out from #2717.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-yto allapt-get installandapt-get updatecommands to prevent process hangs.apt-get installcommands inbuild-cross.Temporatily->Temporarily).