Skip to content

ci: remove unused Windows ninja install and modernize CMake invocation #2846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 4 commits into from
Sep 15, 2026
+7 −13
Merged

ci: remove unused Windows ninja install and modernize CMake invocation #2846

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9cc7b9
ci: Windows Ninja build fix and MSVC updates
kevmoo Sep 6, 2026
46d2871
Merge remote-tracking branch 'origin/main' into win-ninja-build
kevmoo Sep 14, 2026
bec6292
ci: keep Visual Studio generator on Windows, remove unused ninja inst…
kevmoo Sep 14, 2026
4d9f22f
ci: rename tool versions step to cmake version
kevmoo Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,16 @@ jobs:
- name: install ninja (osx)
run: brew install ninja
if: matrix.os == 'macos-latest'
- name: install ninja (win)
run: choco install ninja
if: matrix.os == 'windows-latest'
- name: mkdir
run: mkdir -p out
- name: tool versions
run: |
cmake --version
ninja --version
- name: cmake version
run: cmake --version
- name: ninja version
run: ninja --version
if: matrix.os != 'windows-latest'
- name: cmake
run: cmake .. -G Ninja -DWERROR=ON -Werror=dev -DCMAKE_ERROR_DEPRECATED=OFF
working-directory: out
run: cmake -S . -B out -G Ninja -DWERROR=ON -Werror=dev -DCMAKE_ERROR_DEPRECATED=OFF
if: matrix.os != 'windows-latest'
- name: cmake (windows)
run: cmake .. -DWERROR=ON -Werror=dev -DCMAKE_ERROR_DEPRECATED=OFF
working-directory: out
run: cmake -S . -B out -DWERROR=ON -Werror=dev -DCMAKE_ERROR_DEPRECATED=OFF
if: matrix.os == 'windows-latest'
- name: build
run: cmake --build out
Expand Down
Loading