Repository navigation
release: tiger-core 1.43.0 — views own markup (TIGER-384) - #369
Merged
Merged
Conversation
Every view's JS/CSS moves into a registered asset: 52 views, ~5,400 lines of inline JavaScript. Behaviour is unchanged on every screen — same markup, same /api calls, same strings — but the rule is now enforced by CI rather than written in a docblock. Two real bugs came out of the work. A pageScript() registration made from inside partial() was silently discarded (profile.sms.js had never loaded, so the Phone & SMS card on /profile had no behavior at all), and Tiger_Uuid::timeOf() returned an int on a whole second, breaking its own @return float about one call in a thousand. Thirteen bundled modules gain an assets/ directory for the first time, so they need their public/_modules/<slug> link — publishAllAssets() already runs from tiger migrate, Tiger_Update_Core and link:assets, so a normal update covers it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump + CHANGELOG for 1.43.0, on top of #368.
Tiger_Version::VERSION→1.43.0(the tag-timeversion-checkworkflow asserts the two agree;TIGER_VERSIONderives from this constant, so there is nothing else to bump).What's in it
Changed — every view's JS/CSS is now a registered asset (TIGER-384). 52 views, ~5,400 lines of
inline JavaScript moved out. No screen's behaviour changes: same markup, same
/apicalls, samestrings. Thirteen bundled modules gain an
assets/directory for the first time, so they need theirpublic/_modules/<slug>link —publishAllAssets()already runs fromtiger migrate,Tiger_Update_Coreandtiger link:assets, so a normal update covers it.Fixed — a page asset registered from inside a partial was silently discarded.
partial()rendersagainst a
cloneof the view and ZF1 binds a helper to a view only on first use, so the tag waswritten on a throwaway clone.
profile.sms.jshad never loaded since it shipped. The slot is nowwritten on every distinct view in play, with per-request dedupe.
Fixed —
Tiger_Uuid::timeOf()returned an int on a whole second, breaking its own@return floatabout one call in a thousand.Added — the rule is enforced: a CI guard test that fails on a
<script>/<style>/stylesheet-<link>in any view (and mutation-tests its own matcher), the
javascriptjob widened to syntax-check all 84shipped browser assets, and the AGENTS.md section the helper docblocks had been pointing at.
Checks
CAPABILITIES.mdcurrent; paradigm scan 108 views, 0 findings.with zero inline blobs, sign-in through the extracted login asset, the dashboard grid,
/profileloading all five pane assets including
profile.sms.js, the Translations grid and the mail-providercarrier.