Repository navigation
Rework server networking - #11
Merged
Merged
Conversation
Move ListSpeciesRequest, ListSpeciesResponse and ListSpeciesRequestHandler to be inside "species" namespaces.
PMDDesktop.Requests.ListTypesRequest -> PMDDesktop.Requests.PokemonTypes.ListPokemonTypesRequest PMDDesktop.Requests.ListTypesResponse -> PMDDesktop.Requests.PokemonTypes.ListPokemonTypesResponse PMDDesktop.Server.RequestHandlers.ListTypesRequestHandler -> PMDDesktop.Server.RequestHandlers.ListPokemonTypesRequestHandler
WIP feature!! The code probably doesn't make a whole lot of sense right now!
This splits off of GenericReponseCreators, moving the function that used to live there.
…Error This makes the intention of ResponseResultIndexMissingError more clear. It could be kinda confused with the meaning of ResponseResultDataInvalidError originally.
I forgot that Assert.All() requires you to actually assert something rather than just return true/false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks how the server takes in requests, handles them, and returns responses.
Mostly, minus JsonException and other unhandled exceptions, failures are handled with a Result-Pattern now instead of a giant try-catch where we purposely throw exceptions. This also gives us the chance to write more meaningful and reusable error messages, as each reason for failure is now its own object.