Skip to content

feat: add asm support - #971

Merged
Wilfred merged 2 commits into
Wilfred:masterfrom
Neptunium931:asm
Apr 21, 2026
Merged

Wilfred merged 2 commits into
Wilfred:masterfrom
Neptunium931:asm

Conversation

@Neptunium931

Copy link
Copy Markdown
Contributor

Added assembly using RubixDev/tree-sitter-asm

@Wilfred Wilfred left a comment •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue, and this needs rebasing I'm afraid, but otherwise looks perfect!

Comment thread Cargo.toml Outdated
@Wilfred

Wilfred commented Apr 18, 2026

Copy link
Copy Markdown
Owner

Incidentally, have you used it much? Assembly has very little syntactic structure so I'm wondering how much difftastic helps here.

@Neptunium931

Copy link
Copy Markdown
Contributor Author

Yes, I tested them on projects to see the results, and I found that it allows for a much better visualization of modifications to instructions, operands, or labels.
Above are two examples that highlight the difference.
image

image Note: that this second screenshot was taken with this PR RubixDev/tree-sitter-asm/pull/28 that I submitted and for which I am awaiting a response.

@Neptunium931
Neptunium931 requested a review from Wilfred April 20, 2026 09:08

@Wilfred Wilfred left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just needs rebasing so I can merge it :)

@Neptunium931
Neptunium931 force-pushed the asm branch 2 times, most recently from c3f8775 to dc182d5 Compare April 21, 2026 06:17
@Neptunium931

Copy link
Copy Markdown
Contributor Author

Looks great! Just needs rebasing so I can merge it :)

Done

@Wilfred
Wilfred merged commit 4d7bc66 into Wilfred:master Apr 21, 2026
16 checks passed
@Wilfred

Wilfred commented Apr 21, 2026

Copy link
Copy Markdown
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants