WIRE-360: Remove unsafe auth notification path - #614
Conversation
Change-Id: I2628c5e916d67b31cdf9c1d1f8259e654e4ff5a1
|
I reproduced this in a test, and on master it is worse than the audit rating: a tier-2/3 node owner can take over What the handler can reach
How it is reachable on master
With this PR's wasm, The same claim path accepts Requested changes
With the current CDT, every other contract rebuilds byte-identical to this branch's committed wasm, so only Regression tests The patch below applies to this branch with
Patch (
|
Change-Id: I74dc8d9c48b72d95e6ca88cd586d3607d53f7531
Change-Id: Ifaa3f15b3cf85414c9d1534c64b8abe13dddaaf4
Change-Id: If0257c62d0fe4a633ec171ce67f10aceccdd4e37
|
Addressed in be77471. The obsolete |
|
Thanks. |
Change-Id: Iba8ecf00b26d1e4777c26418c0c001b563fab4c7
Change-Id: Iab4f4f73ec8e9d1969d62c97f3d82e3c97dd8d49
|
Resolved in |
Summary
auth.msg::onlinkauthnotification handler and itsauth.extpermission constant, eliminating the path that let a claimedauth.msgaccount modifysysiopermissions.sysio.prefix through the shared ROA name validator, covering both account creation and registration audit paths.masterwhile retaining both the WIRE-360 reserved-name constant and the new account-name generator constants, then rebuild and synchronizesysio.roa.wasmandsysio.system.wasmfrom the combined source.Why
The previous notification path could be reached by a tier-2/3 node owner that claimed
auth.msg; on the original base it could replacesysio@active. Separately, node owners could claimsysio.*names and receive system-account resource treatment. This PR removes the unused privileged handler entirely and closes the reserved-name gap. Currentmasteralso changed ROA account-name generation and the system contract, so the final generated artifacts must come from the merged source rather than either side of the conflict. The affected functionality is pre-launch, so no migration is required.Validation
BUILD_SYSTEM_CONTRACTS=ON,BUILD_TEST_CONTRACTS=ON, andENABLE_TESTS=ONcontracts_unit_test: all 783 cases passed undersys-vm-jitflow-node-owner-nft: passed against the exact PR head using the current merged wire-tools producer-admission support86d28c461588fd940b461fa0e4ec97b3cdc7c9c4and the exact locally proven cross-repository revisions