Test: Pass the OC option in the query HTTP test only when OC is built - #647
Merged
Merged
Conversation
chain_plugin registers sys-vm-oc-enable only when the OC runtime is compiled in, but the HTTP test passed --sys-vm-oc-enable none to every application it starts. On macOS arm64, which has no OC runtime, each init failed with "Unknown option" and every test case failed. Only the macOS nightly runs nonparallelizable tests, so PR CI never showed it. Append the option only under SYSIO_SYS_VM_OC_RUNTIME_ENABLED, as test_read_only_trx does.
huangminghuang
approved these changes
Sep 26, 2026
huangminghuang
left a comment
huangminghuang
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the current diff and relevant initialization/build context. No actionable findings. The guard matches chain_plugin's option registration, and the test inherits the runtime macro through sysio_chain, preserving the existing arguments on OC-enabled builds.
Validation: git diff --check passed. The integration suite was not run locally; Apple Silicon PR CI excludes this nonparallelizable test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_query_engine_plugin_httppassed--sys-vm-oc-enable noneto every application it starts. chain_plugin registers that option only when the OC runtime is compiled in (SYSIO_SYS_VM_OC_RUNTIME_ENABLED), so on macOS arm64 every init fails withUnknown option '--sys-vm-oc-enable', and the macOS nightly has failed on this test since the query engine landed. macOS PR CI skips nonparallelizable tests, which is why it never showed up there.The option is now appended only when the OC runtime is built, the same guard
tests/test_read_only_trx.cppuses.