Repository navigation
Require eligible producers for finalizer key registration - #657
Merged
Merged
Conversation
Change-Id: Ib3e5a3b9e9855f7c081a93d6aacb9e411189a51d
huangminghuang
marked this pull request as ready for review
September 30, 2026 15:15
heifner
approved these changes
Sep 30, 2026
heifner
left a comment
Contributor
There was a problem hiding this comment.
LGTM. This is the check I asked for: regfinkey now needs an active producer row and an ACTIVE producer operator, cleanup through delfinkey stays open, and the tests cover unregprod, rmvproducer, re-registration, and termination.
Optional: regfinkey reads the producer row twice (contains, then get); a single try_get would do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
producer_rank::is_eligible_operatorbeforeregfinkeyaccepts a finalizer key: the producer row must be active and its operator must have ACTIVE producer status.Why
A producer row can remain after it is deactivated or loses operator eligibility. Checking only that the row exists lets that account continue reserving finalizer keys.
This implements the narrower guard requested in Heifner's review. WIRE-377 remains closed by risk acceptance: cross-account proof replay between eligible producers is still possible. The predicate permits first-key registration and does not restrict deletion of existing keys after eligibility is lost.
Validation
sysio_system_finalizer_key_tests,sysio_producer_eligibility_tests, andgetpeerkeys_tests; 2,297 assertions.