Repository navigation
fix(cluster-tool): send slug_name action fields as their canonical spelling - #108
Merged
Merged
Conversation
…elling
sdk-core's generated types declare slug fields as strings now that slug_name
is an ABI builtin, so the { value } object carrier no longer compiles. Pass the
spelling in RegistrySteps and the opreg setconfig min bonds, convert the test
fixtures, and move slugValue's JSDoc back onto slugValue.
Change-Id: I756d8956a8bb40c41423b7d078bb4a7095854cdd
The reserve-lifecycle, swap-from-wire and swap-private-reserves flows still
built { value } slug carriers from packed codes; convert them with
SlugName.toString.
Change-Id: I7e1c7152cf3c5a3927f3ca77ed05a620db6245c9
Contributor
|
emergency mer because both libraries and tools were broken |
Contributor
Author
|
E2E is green: run 36177781569. All 15 flows passed ( Branch combination: wire-sysio
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slug_nameis now an ABI builtin (wire-sysio#619), and wire-libraries-ts#83 regeneratedSysioContractTypesso every slug field is astring. Action callers here still built{ value: SlugName.from(...) }, which no longer compiles.RegistrySteps(setoutpost,regchain,regtoken,regctok,regreserve) passes the canonical spelling.ClusterBuildDefaults.operatorRegistryConfigconverts the persisted packedchainCode/tokenCodeto spellings for thesetconfigmin bonds. The persistedClusterConfigschema is unchanged.SwapScenarioContext,RegistrySteps,WireReserveTool, and the chains/reserv/tokens contract-step tests) now use real slug spellings.slugValue's JSDoc had drifted ontopackedSlugValue; it is moved back, and the rationale now cites the leading-letter rule.Verified against master sdk-core plus wire-libraries-ts#90: build, cluster-tool 140 suites / 1667 tests, lint.
Depends on a published sdk-core that includes #83 and wire-libraries-ts#90. Merge order: wire-libraries-ts#90, then release PR wire-libraries-ts#89 (1.0.93), then this PR plus the
@wireio/sdk-corebump.