various subtitle changes including ASS format for senshi#109
Merged
Conversation
TruSoggy
marked this pull request as draft
July 12, 2026 09:01
Contributor
Author
|
found another edge case |
Contributor
Author
|
nevermind... senshi just f*d up the ENG subtitle entry... it has barely any lines in it |
TruSoggy
marked this pull request as ready for review
July 12, 2026 11:40
Owner
|
Thanks! would review and merge it now! |
Wraient
approved these changes
Jul 22, 2026
Wraient
left a comment
Wraient
left a comment
Owner
There was a problem hiding this comment.
Looks good — solid fix for Senshi softsubs.
- Prefer validated ASS when present (range-check + Script Info/styles)
- Sanitize broken WebVTT (blank lines splitting cues,
\\hspacing) — matches the 5:14 case - Skip forced/signs tracks before full dialogue
- Wait for MPV path/duration before
sub-addon reused instances - Local VTT cache with size limit + cleanup
Tests cover the new paths. Approving and squash-merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the soft subs breaking in senshi alot.
an example can be found in The Exiled Heavy Knight Knows How to Game the System Episode 2 at around 5:14