Repository navigation
Show script admins with violet names instead of a badge - #1049
Merged
Merged
Conversation
The 脚本管理员 badge plus a custom badge often wrapped onto a second line. Admins now get a reserved violet username color with a 脚本管理员 tooltip, whether or not ratings are shown, and the badge is removed. No rating tier uses violet, so it cannot be mistaken for a rating. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E5dr7XTsCeoamqLSiT9rLp
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR changes script-admin identification from a separate badge to a reserved violet username color with a 脚本管理员 tooltip, ensuring the marker works across rating and UI modes while leaving custom badges available. Flow diagram for script-admin username renderingflowchart TD
A[GetUsernameHTML] --> B{AdminUserList includes Username}
B -- Yes --> C[Add title 脚本管理员]
C --> D[Apply xmoj-rating-admin violet class]
D --> E[Render custom badge when not Simple]
B -- No --> F{Rating enabled}
F -- Yes --> G[Apply rating tier class]
F -- No --> H[Render default username color]
G --> E
H --> E
E --> I[No 脚本管理员 badge]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Deploying xmoj-script-dev-channel with
|
| Latest commit: |
98ac80c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41082cd2.xmoj-script-dev-channel.pages.dev |
| Branch Preview URL: | https://admin-violet-names.xmoj-script-dev-channel.pages.dev |
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="XMOJ.user.js">
<violation number="1" location="XMOJ.user.js:707">
P2: This hover/focus shade has only 3.03:1 contrast against the dark skin background (`#1a1a1a`), below the palette’s stated 3.3:1 minimum. Lighten it to a darker-than-base violet such as `#9b59dd`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Script admins showed a 脚本管理员 badge next to their username. Together with a custom badge, the two often wrapped onto a second line. This PR marks admins with a reserved violet username color instead, which frees the space for their own badge.
Docs PR: XMOJ-Script-dev/docs#10
How does this PR accomplish the above?:
GetUsernameHTML, users inAdminUserListget the newxmoj-rating-adminclass and atitle="脚本管理员"tooltip. The old commented-outlink-fuchsiasketch was the same idea.Ratingoption is on, like the badge did.GetUserBadgeare unchanged.RatingColorCSSgains violet#a855f7with hover#8644c6, darkened 20% like the other tiers.#1a1a1a.GetUsernameHTMLwith stubbed user info and badge lookups:By submitting this pull request, I confirm the following:
🤖 Generated with Claude Code
https://claude.ai/code/session_01E5dr7XTsCeoamqLSiT9rLp
Summary by Sourcery
Replace the script administrator badge with violet username styling to free space for custom badges.
New Features:
Enhancements:
Build:
Summary by cubic
Shows script admins with reserved violet usernames and a
脚本管理员tooltip instead of a separate badge, freeing space for custom badges.Update.json.Written for commit 98ac80c. Summary will update on new commits.