Skip to content

fix: Skip NFT pages for filtered account_objects - #3231

Open
GautamBytes wants to merge 1 commit into
XRPLF:developfrom
GautamBytes:fix/skip-nft-on-filter
Open

GautamBytes wants to merge 1 commit into
XRPLF:developfrom
GautamBytes:fix/skip-nft-on-filter

Conversation

@GautamBytes

@GautamBytes GautamBytes commented Sep 25, 2026 •

Copy link
Copy Markdown

Summary

  • Skip NFTokenPage traversal for account_objects when the effective type filter excludes NFT pages.
  • Preserve the pagination budget for matching owner-directory objects.
  • Add an NFT-heavy regression case and update affected filtered-type test expectations.

Fix #3060

@godexsoft

Copy link
Copy Markdown
Collaborator

@GautamBytes please rebase your rpc-spec PR onto the new develop (had to force-push to fix linear history in rpc-spec repo). Thanks

@mathbunnyru

mathbunnyru commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

@GautamBytes and please sign your commit
I highly suggest setting up your git profile so your commits are always signed

@GautamBytes
GautamBytes force-pushed the fix/skip-nft-on-filter branch from 7839ad8 to 744603d Compare September 28, 2026 17:20
@GautamBytes

Copy link
Copy Markdown
Author

@GautamBytes and please sign your commit I highly suggest setting up your git profile so your commits are always signed

done!!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

account_objects unconditionally walks NFT pages even when type filter excludes NFTokenPage

3 participants