Skip to content

fix: Reject CTID network IDs above 16 bits - #3232

Open
GautamBytes wants to merge 1 commit into
XRPLF:developfrom
GautamBytes:fix/ctid-network-id
Open

GautamBytes wants to merge 1 commit into
XRPLF:developfrom
GautamBytes:fix/ctid-network-id

Conversation

@GautamBytes

@GautamBytes GautamBytes commented Sep 25, 2026 •

Copy link
Copy Markdown

Summary

  • Preserve the full 32-bit ETL network ID until CTID range validation, so IDs above 65535 cannot be truncated into misleading CTIDs.
  • Keep expanded transaction JSON on the same 32-bit path.
  • Add focused encoder and tx handler regression tests.

Fix #3158

@mathbunnyru

Copy link
Copy Markdown
Collaborator

@GautamBytes could you please sign your commit?

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@GautamBytes

Copy link
Copy Markdown
Author

@GautamBytes could you please sign your commit?

DONE

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CTID encoder truncates "network_id" values above "65535"

2 participants