chore: Conform to latest rpc-spec 0.1.19 - #3233
Merged
godexsoft merged 5 commits intoSep 28, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
mathbunnyru
previously approved these changes
Sep 28, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates Clio for xrpl-rpc-spec 0.1.19, including the RippledError rename and Boost.JSON backend decoupling.
Changes:
- Renames RPC error types to
XrpldError. - Introduces shared
SpecBackendaliases and generated JSON instantiations. - Updates error serialization and tests.
| File | Description |
|---|---|
| tests/unit/web/RPCServerHandlerTests.cpp | Updated as part of this pull request. |
| tests/unit/web/ng/RPCServerHandlerTests.cpp | Updated as part of this pull request. |
| tests/unit/web/ng/impl/ErrorHandlingTests.cpp | Updated as part of this pull request. |
| tests/unit/web/impl/ErrorHandlingTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/RPCHelpersTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/RPCEngineTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/VaultInfoTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/UnsubscribeTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/TxTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/TestHandlerTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/SubscribeTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/LedgerTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/LedgerEntryTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/LedgerDataTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/CredentialHelpersTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/AccountOffersTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/AccountLinesTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/AccountInfoTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/handlers/AccountCurrenciesTests.cpp | Updated as part of this pull request. |
| tests/unit/rpc/ErrorTests.cpp | Updated as part of this pull request. |
| tests/unit/app/WebHandlersTests.cpp | Updated as part of this pull request. |
| tests/common/rpc/FakesAndMocks.hpp | Updated as part of this pull request. |
| tests/common/rpc/FakesAndMocks.cpp | Updated as part of this pull request. |
| src/web/RPCServerHandler.hpp | Updated as part of this pull request. |
| src/web/ng/RPCServerHandler.hpp | Updated as part of this pull request. |
| src/web/ng/impl/ErrorHandling.hpp | Updated as part of this pull request. |
| src/web/ng/impl/ErrorHandling.cpp | Updated as part of this pull request. |
| src/web/LoadWarning.hpp | Updated as part of this pull request. |
| src/web/impl/WsBase.hpp | Updated as part of this pull request. |
| src/web/impl/HttpBase.hpp | Updated as part of this pull request. |
| src/web/impl/ErrorHandling.hpp | Updated as part of this pull request. |
| src/rpc/RPCHelpers.cpp | Updated as part of this pull request. |
| src/rpc/RPCEngine.hpp | Updated as part of this pull request. |
| src/rpc/README.md | Updated as part of this pull request. |
| src/rpc/handlers/VaultInfo.hpp | Updated as part of this pull request. |
| src/rpc/handlers/VaultInfo.cpp | Updated as part of this pull request. |
| src/rpc/handlers/Unsubscribe.hpp | Updated as part of this pull request. |
| src/rpc/handlers/Tx.hpp | Updated as part of this pull request. |
| src/rpc/handlers/TransactionEntry.hpp | Updated as part of this pull request. |
| src/rpc/handlers/TransactionEntry.cpp | Updated as part of this pull request. |
| src/rpc/handlers/Subscribe.hpp | Updated as part of this pull request. |
| src/rpc/handlers/ServerInfo.hpp | Updated as part of this pull request. |
| src/rpc/handlers/NoRippleCheck.hpp | Updated as part of this pull request. |
| src/rpc/handlers/NoRippleCheck.cpp | Updated as part of this pull request. |
| src/rpc/handlers/NFTsByIssuer.hpp | Updated as part of this pull request. |
| src/rpc/handlers/NFTsByIssuer.cpp | Updated as part of this pull request. |
| src/rpc/handlers/NFTOffersCommon.hpp | Updated as part of this pull request. |
| src/rpc/handlers/NFTOffersCommon.cpp | Updated as part of this pull request. |
| src/rpc/handlers/NFTInfo.hpp | Updated as part of this pull request. |
| src/rpc/handlers/NFTInfo.cpp | Updated as part of this pull request. |
| src/rpc/handlers/NFTHistory.hpp | Updated as part of this pull request. |
| src/rpc/handlers/NFTHistory.cpp | Updated as part of this pull request. |
| src/rpc/handlers/MPTokenIssuanceHistory.hpp | Updated as part of this pull request. |
| src/rpc/handlers/MPTokenIssuanceHistory.cpp | Updated as part of this pull request. |
| src/rpc/handlers/MPTHolders.hpp | Updated as part of this pull request. |
| src/rpc/handlers/MPTHolders.cpp | Updated as part of this pull request. |
| src/rpc/handlers/LedgerIndex.hpp | Updated as part of this pull request. |
| src/rpc/handlers/LedgerIndex.cpp | Updated as part of this pull request. |
| src/rpc/handlers/LedgerEntry.hpp | Updated as part of this pull request. |
| src/rpc/handlers/LedgerEntry.cpp | Updated as part of this pull request. |
| src/rpc/handlers/LedgerData.hpp | Updated as part of this pull request. |
| src/rpc/handlers/LedgerData.cpp | Updated as part of this pull request. |
| src/rpc/handlers/Ledger.hpp | Updated as part of this pull request. |
| src/rpc/handlers/GetAggregatePrice.hpp | Updated as part of this pull request. |
| src/rpc/handlers/GatewayBalances.hpp | Updated as part of this pull request. |
| src/rpc/handlers/GatewayBalances.cpp | Updated as part of this pull request. |
| src/rpc/handlers/Feature.hpp | Updated as part of this pull request. |
| src/rpc/handlers/Feature.cpp | Updated as part of this pull request. |
| src/rpc/handlers/DepositAuthorized.hpp | Updated as part of this pull request. |
| src/rpc/handlers/DepositAuthorized.cpp | Updated as part of this pull request. |
| src/rpc/handlers/BookOffers.hpp | Updated as part of this pull request. |
| src/rpc/handlers/BookChanges.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AMMInfo.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AMMInfo.cpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountTx.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountTx.cpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountOffers.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountOffers.cpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountObjects.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountObjects.cpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountNFTs.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountNFTs.cpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountMPTokens.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountMPTokens.cpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountMPTokenIssuances.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountMPTokenIssuances.cpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountLines.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountLines.cpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountInfo.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountInfo.cpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountCurrencies.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountCurrencies.cpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountChannels.hpp | Updated as part of this pull request. |
| src/rpc/handlers/AccountChannels.cpp | Updated as part of this pull request. |
| src/rpc/Factories.cpp | Updated as part of this pull request. |
| src/rpc/Errors.hpp | Updated as part of this pull request. |
| src/rpc/Errors.cpp | Updated as part of this pull request. |
| src/rpc/CredentialHelpers.cpp | Updated as part of this pull request. |
| src/rpc/common/SpecBackend.hpp | Updated as part of this pull request. |
| src/rpc/common/impl/Processors.hpp | Updated as part of this pull request. |
| src/rpc/common/Concepts.hpp | Updated as part of this pull request. |
| src/rpc/CMakeLists.txt | Updated as part of this pull request. |
| src/app/WebHandlers.hpp | Updated as part of this pull request. |
| src/app/WebHandlers.cpp | Updated as part of this pull request. |
| conanfile.py | Updated as part of this pull request. |
| conan.lock | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mathbunnyru
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses spec 0.1.19 which renamed RippledError to XrpldError to stay compatible with xrpld alongside few other fixes for decoupling from boost::json that happened in 0.1.18.