fix: rebind Create Symbolic Link shortcut to Cmd+Opt+L to resolve Make Active collision

[YuriNachos]

Problem

Two items in the Xcode CommandMenu bind the same keyboard shortcut (⌘⌥S), so one of them can never be triggered from the keyboard:

• SelectCommand ("Make Active") — XcodeCommands.swift .keyboardShortcut("s", modifiers: [.command, .option])
• CreateSymbolicLinkCommand ("Create Symbolic Link") — same .keyboardShortcut("s", modifiers: [.command, .option])

SwiftUI resolves duplicate .keyboardShortcut modifiers silently: both menu items render the ⌘⌥S glyph, but pressing ⌘⌥S only ever fires Make Active (the first-declared binding). Create Symbolic Link is unreachable from the keyboard. There is no compiler warning and no runtime error — the regression is invisible without manual testing.

Solution

Rebind CreateSymbolicLinkCommand to ⌘⌥L ("L" for Link). L is unused among the menu's current letters (S / ↓ / R / C / U / I), it is the natural mnemonic for "Link", and Make Active stays on S.

To make this silent class of regression testable, the six always-on command shortcuts are centralized in a small enum XcodeCommandShortcuts namespace of static let KeyboardShortcut constants, and the six Command views read from those constants. A new XcodeCommandShortcutsTests asserts the six are pairwise distinct — turning a future duplicate binding into a failing build instead of a silently-broken menu.

• Make Active stays on ⌘⌥S (unchanged).
• Create Symbolic Link moves ⌘⌥S → ⌘⌥L (the fix).
• The other four (Open ⌘↓, Reveal ⌘⌥R, Copy Path ⌘⌥C, Uninstall ⌘⌥U) are byte-identical, just routed through the seam.
• The conditional Install ("⌘⌥I") / Cancel Install ("⌘.") shortcuts are mutually exclusive and intentionally not added to the seam.

Impact

• The five preserved commands are 1:1 (same key + same modifiers, verified via git show main:…/XcodeCommands.swift).
• Localizable.xcstrings is untouched — the menu glyph is rendered from the keyboardShortcut modifier, and CreateSymbolicLinkButton.help("CreateSymLink") is a localization key, not a hardcoded glyph, so the 18-language xcstrings.yml CI is not affected.
• Only XcodeCommands.swift behavior + a new pure-logic test; no model/AppState change.

Testing

• Red before green. With the XcodeCommandShortcuts seam mirroring the old (buggy) values (makeActive = ⌘⌥S and createSymbolicLink = ⌘⌥S), XcodeCommandShortcutsTests fails (two shortcuts collide). After rebinding createSymbolicLink to ⌘⌥L, it passes.
• Mutation check. Reverting createSymbolicLink back to "s" re-fails the test (proves the guard is not theater), then restored to "l".
• xcodebuild test -scheme Xcodes -destination 'platform=macOS' CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO -only-testing:XcodesTests/XcodeCommandShortcutsTests → TEST SUCCEEDED (1 test, 0 failures).
• Adversarial review (logic + behavior-equivalence + test-integrity/pbxproj) returned APPROVE with no blocking findings.

Checklist

• Diff scoped to XcodeCommands.swift + new test + test-target registration in project.pbxproj (registration only).
• Localizable.xcstrings byte-identical to main.
• No new compiler warnings.

---

Authored by @YuriNachos. Implementation written by a cccc (Claude Code, GLM-5.2) worker under orchestrator acceptance — gate green and an independent adversarial review returned APPROVE with no blocking findings.