Skip to content

fix: accept published pairing URI scheme - #52

Closed
YashasVM wants to merge 2 commits into
agent/B1-baselinefrom
agent/P2-pairing-link
Closed

YashasVM wants to merge 2 commits into
agent/B1-baselinefrom
agent/P2-pairing-link

Conversation

@YashasVM

@YashasVM YashasVM commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Accept both openstream://connect and current shin://connect pairing URLs.
  • Reject malformed URI authorities and host syntax, oversized/empty inputs, and invalid port, latency, or bitrate values.
  • Validate IPv4, hostname, and IPv6 syntax locally without DNS or network access.
  • Add pairing parser behavior coverage and update the repository contract for both schemes and strict validation.

Evidence

I inspected the published v1.0.1 Windows ZIP's openstream-obs.dll and found the literal openstream://connect pairing scheme. The Android manifest already registers both schemes. Android unit and repository tests pass. Real phone click-through remains unverified.

Validation

  • python -m pytest -q — 115 passed
  • ANDROID_HOME=/home/yvm/.local/share/android-sdk ./gradlew :app:testDebugUnitTest — passed

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 35d2fa02-b529-4fea-8226-943d99821868

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@YashasVM YashasVM left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yashas's code review bot: Reviewed the latest pairing-parser changes. The implementation is narrowly scoped, preserves the current shin://connect path while restoring the published openstream://connect scheme, rejects malformed authorities and invalid bounded parameters, and validates hosts without introducing DNS/network work. The new parser coverage is meaningful, the PR is mergeable, and Android, Windows OBS, Linux OBS, and Website workflows all pass on this exact head. I found no remaining correctness, security, or merge-blocking issue in this PR. Real phone click-through is still useful release acceptance evidence, but it does not block this parser fix. This PR is safe to merge.

@YashasVM YashasVM closed this Sep 25, 2026
@YashasVM
YashasVM deleted the agent/P2-pairing-link branch September 28, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant