Repository navigation
Close a question skipped in the Claude app at the turn's end (pm-harness sprint 130) - #124
Merged
Merged
Conversation
…ess sprint 130) Through Remote Control, skipping an AskUserQuestion dialog in the Claude app returns "Denied by user" to the agent but fires no PostToolUse and sends the waiting PermissionRequest hook no signal, so the question stayed open on the site until the session's process exited (18 h in one poker session). No dialog outlives its turn, so Claude Code's Stop hook now runs pm hook ask, which closes the session's questions still open as dismissed; the waiting hook sees the close and exits. Codex keeps its questions open past the turn by design, so this is Claude Code only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… Stop hook in the harness Picking the dialog's Chat about this rejects AskUserQuestion like an app's skip: no PostToolUse, no signal to the waiting hook (Claude Code 2.1.311). The Stop close already covers it; the close reason and docs now name it. The harness's CLAUDE_PM lists the new Stop command, and the misplaced Codex test comment is back on its test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Claude Code question the owner skips in the Claude app (Remote Control,
claude rc) stayed under "Sessions ask you" until the session's process exited: Claude Code returns "Denied by user" to the agent but fires no PostToolUse and sends the waitingpm hook askno signal. One poker session's question stayed open 18 h this way.pm hook ask --runtime claude; at Stop it closes the session's questions still open as dismissed ("the turn ended without an answer: the owner skipped the question in the Claude app"). No dialog outlives its turn, so none is open at Stop. The waiting PermissionRequest hook sees the close and exits.runtimeDifferencesgives the Stop difference its reason.owner-questions: the measured fact, the sequence branch, the chat-answer table.Checks:
go test ./internal/hooks ./internal/install ./internal/cliok; the new test fails with the Stop branch disabled;make test159 passed. Live, in this repo's real store: before the fix, an AskUserQuestion skipped in the app left need open and its hook waiting for 16 min; the built pm run on a Stop event for that session closed it as dismissed, the waiting hook exited and the site dropped the card. Esc and a killed terminal were also re-checked on Claude Code 2.1.311: both still close as dismissed.🤖 Generated with Claude Code