feat: support fractional preload cache percentage - #803
Open
akir-dev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow PreloadCache to use fractional percentage values with precision up to two decimal places.
Use case
For large movies over 50 GB, users storing the cache on disk may configure a large cache so the entire movie can fit in it. Currently, the minimum preload value is effectively 1%. With a large disk cache, even 1% can represent a
significant amount of data, resulting in unnecessarily long preloading before playback starts.
Fractional values such as 0.1% or 0.25% allow users to keep a large disk cache while configuring a much smaller preload buffer and starting playback sooner.
Changes