Repository navigation
chore: Update phpmd schema files to 2.0.0 - #77
Merged
Merged
Conversation
Previously, testing-suite would fail `xmllint` (on itself) with a `Failed to locate the main schema resource at 'https://pmd.sourceforge.io/ruleset_xml_schema.xsd'` errors. This commit make sure to update to the correct references, while also making sure local references can be fetched (by altering the grummphp file's `xmllint.ignore.patterns`)
rutgerrademaker
requested review from
CyberSecutor,
igorwulff,
kjkooistra-youwe,
leonhelmus and
youwe-petervanderwal
August 24, 2026 08:58
CyberSecutor
approved these changes
Aug 24, 2026
kjkooistra-youwe
approved these changes
Aug 24, 2026
youwe-petervanderwal
approved these changes
Aug 25, 2026
Anve94
reviewed
Aug 25, 2026
| <!--<exclude-pattern>path/to/exclude/*</exclude-pattern>--> | ||
| <rule ref="./vendor/youwe/testing-suite/config/default/phpmd.xml" /> | ||
| </ruleset> | ||
| <rule ref="./vendor/youwe/testing-suite/config/pimcore/phpmd.xml" /> |
Contributor
There was a problem hiding this comment.
@rutgerrademaker Is this intended? Since config/default/phpmd.xml is updated too in same PR
Contributor
There was a problem hiding this comment.
Thanks for spotting that issue, fixed in PR #78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, testing-suite would fail
xmllint(on itself) with aFailed to locate the main schema resource at 'https://pmd.sourceforge.io/ruleset_xml_schema.xsd'errors.This commit make sure to update to the correct references, while also making sure local references can be fetched (by altering the grummphp file's
xmllint.ignore.patterns)