Repository navigation
Conversation
|
@loopyreviews-bot review |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
@loopyreviews-bot review |
Keep both guide additions: the Later corrections paragraph from main and the processing and results screens section.
|
@loopyreviews-bot review |
Loopy reviewConfidence: 5/5 — No open findings. Reviewed 4 of 10 changed files. UI phase 3 adds four pages (Processing queue, Processing live, Match results, Field map) and wires them into MainWindow. A persistent processing_jobs queue runs each job through the existing process() path, with the job's sampling rate, tracking mode and model. The run log is relayed to the live page, and the sidebar and shortcuts are updated. I reviewed main_window.py and fieldmap_page.py and found no new defects beyond those already dismissed.
Review passes: 4 ran (general ×2, failure-paths, state) · 16 unit and lens pair(s) carried over from earlier reviews · 6 planned unit and lens pair(s) left out by the budget. Ran on: Claude on a Mac. Muse on a Mac: no Mac took the review in time. Reviews: 6 · last reviewed |
The pipeline writes "Processed 1,234 of 5,000 sampled frames"; the live page lost its frame count and time left once a run passed 999 sampled frames.
Cancel or Stop processing on the running job no longer starts the next match; Start queue carries on.
|
@loopyreviews-bot review |
…not start Start queue while another run is active pauses the queue and says so. An error while a job starts fails that job with the reason, restores the user's settings and pauses the queue instead of leaving the job running forever.
|
@loopyreviews-bot review |
… run The failure goes through processing_failed, so the match is not left running, Process is enabled again and the run log is detached and closed.
|
@loopyreviews-bot review |
A match that already waits (retried from the live page) is skipped, and a match that failed more than once gets one job.
|
@loopyreviews-bot review |
|
@loopyreviews-bot review |
UI phase 3 from the 23-page UI guide: Processing queue, Processing live, Match results and Field map (guide pages 13–16). Built on main after #34, #37 and #38.
What changes
processing_jobstable keeps the queue across restarts. You can add matches, reorder, remove, clear finished jobs and retry failed ones, and start or pause the queue.MainWindow.process()path as a single match, with that job's sampling rate, tracking mode and model. Your own settings are restored afterwards. Re-seeds from Store reviewer re-seed clicks and apply them on the next run #38 therefore apply to queued jobs as well.match_periods_s. The page says it assumes the video starts at match start.match_scoreboard(confirmed events only, the same rules as Score and export). Each total sits next to the official score you enter, never merged, with a ±10% check.docs/USER_GUIDE.mdhas a new "Processing and results screens" section.Screenshots
These use demo jobs, positions, events and log lines on the real footage, so the layout can be seen without a full run. The numbers in them are not results.
Tests
tests/test_processing_pages.pycovers:The suites in
test_modern_uiandtest_setup_pagesstill pass.Next
The next UI PR moves the window to
FluentWindowand these pages onto the qfluentwidgets components from #40.