Repository navigation
feat: re-approval path for approve-rule with explicit changelog - #2453
Open
WilcoFiers wants to merge 2 commits into
Open
WilcoFiers wants to merge 2 commits into
WilcoFiers wants to merge 2 commits into
Conversation
Archive the previous approved rule and require explicit change entries when approving an updated rule. Co-authored-by: Cursor <cursoragent@cursor.com>
❌ Deploy Preview for act-rules failed.
|
Co-authored-by: Cursor <cursoragent@cursor.com>
WilcoFiers
requested review from
daniel-montalvo
and
a lite review from Copilot
September 22, 2026 12:35
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Workflow changelog forwarding is incomplete, and same-day re-approvals can overwrite archived snapshots.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Adds re-approval support for ACT rules, including archived snapshots, changelog handling, focused tests, and CI coverage.
Changes:
- Archives prior approved rule versions.
- Parses explicit changelog entries from CLI flags or YAML.
- Updates version history and approval workflows.
- Adds tests and CI integration.
Unresolved issues include missing workflow changelog forwarding and same-day snapshot overwrite risk.
| File | Summary |
|---|---|
README.md |
Documents changelog inputs; workflow invocation remains incomplete. |
package.json |
Adds approval-script tests. |
.github/workflows/test.yml |
Runs approval-script tests in CI. |
.github/scripts/update-rule-versions.test.mjs |
Tests version updates and changelog parsing. |
.github/scripts/update-rule-versions.mjs |
Updates version history and archives snapshots; same-day collisions remain possible. |
.github/scripts/archive-rule-snapshot.test.mjs |
Tests archived snapshot rewriting. |
.github/scripts/archive-rule-snapshot.mjs |
Rewrites archived snapshot metadata. |
.github/scripts/approve-rule.mjs |
Integrates re-approval and changelog handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+55
to
+56
| file: `${currentIndex.isoDate}.md`, | ||
| url: `${ruleId}/${currentIndex.isoDate}/`, |
|
|
||
| This repository automatically pushes changes to rules to the [w3c/wcag-act-rules](https://github.com/w3c/wcag-act-rules/) repository. There is an "Approve rule" action available which can be triggered manually by an ACT Task Force facilitator, which will set a proposed rule to "approved". | ||
|
|
||
| Rule updates require an explicit changelog when using the approval script. Pass entries with repeated `--change "..."` flags, with `--changesFile path.yaml` containing a YAML list of strings, or with both. First-time approvals do not require a changelog. |
Collaborator
|
@WilcoFiers Before getting into reviewing this -- is there any reason we are removing the semiclons at the end fo each statement? Keeping them would make it for a much cleaner diff |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.mdunder its ISO date--changeflags and/or a YAML--changesFileTest plan
npm run test:approve-rule(5 passed)npm test -- --runInBand(11 suites, 9704 tests passed)Closes act-rules/act-tools#64