fix: keep deprecated rule issues open on act-board - #72
Closed
WilcoFiers wants to merge 1 commit into
Closed
WilcoFiers wants to merge 1 commit into
WilcoFiers wants to merge 1 commit into
Conversation
Closing an act-board issue makes GitHub Projects v2 move its card to the Done option, which the ACT board renames "Approved, current". Deprecated rules were therefore shown as approved and current, regardless of the Deprecated status the Project sync writes. Every rule in the classifier snapshot now keeps an open issue, and issues closed by earlier runs are reopened. Deprecated still shows in the issue body and as the Project Status. Issues for rules missing from the snapshot are still closed, so those cards can still land in Done. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
Closing unmerged: the root cause is on the Project side, not in the upsert. The board's Status options are the renamed Projects v2 defaults, so the built-in "Item closed -> set Status: Done" workflow drops any closed issue into Approved, current. Disabling that workflow (plus "Item reopened" and "Item added to project", since the bot owns Status) fixes it for deprecated rules and for snapshot-missing/duplicate issues, which this PR left broken. Keeping deprecated issues open also conflicts with the plan in #60, where a deprecated rule's issue is closed and drops out of the default table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated rules showed up on the ACT board under Project Status Approved, current instead of Deprecated.
Cause
upsertActBoardIssuesclosed the act-board issue for every rule with statusDeprecated. GitHub Projects v2 moves a closed item to theDoneoption, and on the ACT board that option is renamed Approved, current ("This has been completed"). TheDeprecatedstatus thatsync-act-board-projectwrites was overwritten by that built-in workflow, so the deprecated rules ended up in the bucket for approved and current rules, which is otherwise empty.Fix
**Status:** Deprecated, and project sync still sets Project Status toDeprecatedfor those rows; nothing is skipped there.Done/ Approved, current; they are not in the snapshot, so project sync no longer writes a status for them. If that turns out to be confusing, a follow-up could set their status explicitly before closing.Tests
src/approval-report/__tests__/act-board.test.tscovered the old behaviour ("closes deprecated and snapshot-missing rule issues"). It now asserts that a deprecated rule issue stays open while a snapshot-missing one is closed, plus new cases for reopening a previously closed deprecated issue and creating a deprecated rule issue as open. All 100 tests insrc/approval-reportpass.Part of #60