fix: use 'internal' visibility for ghe.com - #182
Open
dnwe wants to merge 1 commit into
Open
Conversation
Public repositories are not supported in GitHub Enterprise Cloud with data residency and must be mirrored as 'internal' at most: https://docs.github.com/en/enterprise-cloud@latest/admin/data-residency/about-github-enterprise-cloud-with-data-residency#repository-visibility Without this actions-sync errors with: 422 Public repositories are not permitted for Enterprise Managed Organizations. [] The code already existed in actions-sync to handle this, but was still tied to the old "Aegis" codename. GitHub AE (GHAE) no longer exists as an active standalone product having been deprecated in July 2022, and the final 2-year transition window for legacy customer agreements concluded in July 2024, so it should be fine to repurpose this for detecting foo.ghe.com instances which are the replacement and have the same characteristics. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Author
|
@philip-gai FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public repositories are not supported in GitHub Enterprise Cloud with data residency and must be mirrored as 'internal' at most: https://docs.github.com/en/enterprise-cloud@latest/admin/data-residency/about-github-enterprise-cloud-with-data-residency#repository-visibility
Without this actions-sync errors with:
422 Public repositories are not permitted for Enterprise Managed Organizations. []
The code already existed in actions-sync to handle this, but was still tied to the old "Aegis" codename. GitHub AE (GHAE) no longer exists as an active standalone product having been deprecated in July 2022, and the final 2-year transition window for legacy customer agreements concluded in July 2024, so it should be fine to repurpose this for detecting foo.ghe.com instances which are the replacement and have the same characteristics.