fix: remove mongodb advanced options and ignore legacy params - #654
Open
LordofAvernus wants to merge 1 commit into
Open
fix: remove mongodb advanced options and ignore legacy params#654LordofAvernus wants to merge 1 commit into
LordofAvernus wants to merge 1 commit into
Conversation
PR Reviewer Guide 🔍(Review updated until commit 0a1dc97)
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
sjjian
force-pushed
the
dev-decathlon-mongo-odc-visibility
branch
from
July 27, 2026 08:29
b41a649 to
0a1dc97
Compare
|
Persistent review updated to latest commit 0a1dc97 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/dms-ee/issues/941
描述你的变更
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
在 DBService 中过滤 MongoDB 过时参数
新增 mongo_legacy_params.go 辅助过滤逻辑
SQL Workbench 移除 legacy 参数处理逻辑
更新单元测试验证过滤行为
Diagram Walkthrough
File Walkthrough
db_service.go
增加 MongoDB 参数过滤逻辑internal/dms/service/db_service.go
AddDBServiceV2
sql_workbench_service.go
移除 SQL Workbench legacy 参数处理internal/sql_workbench/service/sql_workbench_service.go
mongo_legacy_params.go
新增 MongoDB 过滤辅助模块internal/dms/service/mongo_legacy_params.go
sql_workbench_service_test.go
更新单元测试验证参数过滤internal/sql_workbench/service/sql_workbench_service_test.go