[hathach]

Problem

pre-commit has been failing on master since #616. That PR passed its checks on a base older than #633 and added metro_m4_express to test/hil/ci.json with an explicit flasher. agentrc's board registry (at the pin in test/hil/agentrc.json) already registers that probe, so test_every_ci_board_loads_with_its_registered_flasher refuses the entry:

metro_m4_express: probe 000063728691 is registered (metro_m4_express): name it as "probe": "000063728691" instead

Every open PR inherits this failure, #641 among them.

Solution

Name the board by "probe": "000063728691", like every other ci.json board. The registry resolves the same flasher as before: jlink, uid 000063728691, -device ATSAMD51J19.

pre-commit run --all-files passes locally with agentrc at the CI pin.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The Metro M4 Express HIL configuration now specifies a probe identifier instead of explicit J-Link flasher settings. The tinyUF2 reentry setting is unchanged.

Changes: HIL board configuration

Layer / File(s)	Summary
Metro M4 Express probe entry test/hil/ci.json	The entry now specifies a probe identifier and omits the explicit J-Link flasher name, UID, and device arguments. The tinyUF2 reentry setting is unchanged.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related issues

• hil: ci.json's metro_m4_express entry lacks the probe key, so test_hil fails on master #643: Identifies the Metro M4 Express roster failure addressed by adding the probe identifier.

Possibly related PRs

• adafruit/tinyuf2#633: Establishes the HIL contract that this entry now follows: specify a probe and resolve the flasher from agentrc.
• adafruit/tinyuf2#639: Contains the same Metro M4 Express probe configuration change.
• adafruit/tinyuf2#616: Adds the Metro M4 Express entry that this change updates to the probe-based form.

Suggested reviewers: greptile-apps

Merge Risk: Minimal · up to 03b51

This change only updates a test configuration entry to use the registered probe, and the resolved flasher is unchanged. It should fix the reported pre-commit failure with no meaningful merge risk.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the main change: naming the metro_m4_express board by its registered probe.
Description check		The description explains the pre-commit failure, the configuration change, and the expected resolved flasher.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: adafruit/tinyuf2
• Branch: limor-641
• File: .coderabbit.yaml
• Commit: 03b514e
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4aedd351-b0fe-4029-98b5-01f99dad89ca

Commits

Reviewing files that changed from the base of the PR and between dc2f6f8 and 03b514e.

Files selected for processing: 1

• test/hil/ci.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

[greptile-apps]

Confidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Changes metro_m4_express in test/hil/ci.json to reference probe: "000063728691" instead of inline J-Link settings.

• The Metro HIL board uses its registered probe.

_{Reviews (1) · Last reviewed commit: "hil: name metro_m4_express by its regist..." · Reviewed by Greptile}

[github-actions]

Hardware-in-the-loop (HIL) Test Report

ci.json (ci.lan)

PR head 03b514e · tested e762c49 · run 42983574946, attempt 2

Every roster board: the HIL runner or a roster changed (8 boards).

✅ 7 passed · ⚪ 1 not run · HIL driver elapsed 10m37s

Board	install	dfu	copy	app-ran	reenter	recopy	blinky	admit	run
espressif_esp32s3_devkitm_1	✅	✅	✅	✅	✅	✅	✅	0s	2m17s
espressif_p4_function_ev	✅	✅	✅	✅	✅	✅	✅	0s	2m23s
imxrt1064_evk	✅	✅	✅	✅	✅	—	✅	1s	41s
lpcxpresso55s69	✅	✅	✅	✅	✅	—	✅	0s	1m32s
max32666fthr	❌					—		1s	1s
metro_m4_express	✅	✅	✅	✅	✅	—	✅	0s	1m33s
stm32f407disco	✅	✅	✅	✅	✅	—	✅	0s	1m40s
stm32h743nucleo	✅	✅	✅	✅	✅	—	✅	0s	29s

✅ passed · ❌ failed · blank not run · — not in this board's run · run time includes lock wait and blinky

• max32666fthr install: the openocd flash failed (exit 1) (nothing written)

Records, reports and logs