Repository navigation
docs(flow-outcomes): troubleshoot skipped outcome actions, Test on device runs only success outcomes - #880
Merged
Conversation
…ns only success outcomes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…omes facts, ripple and open preview question Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eandreeva-twr
marked this pull request as ready for review
November 20, 2026 07:14
eandreeva-twr
added a commit
that referenced
this pull request
Nov 20, 2026
* post-purchase branching * review * docs(flow-outcomes): troubleshoot skipped outcome actions, Test on device runs only success outcomes (#880) * docs(flow-outcomes): troubleshoot skipped outcome actions, preview runs only success outcomes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(context-mill): flow-logic brief — purchase and restoration outcomes facts, ripple and open preview question Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * review --------- Co-authored-by: dbastrikin <dbastrikin@adapty.io> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Eugene Titerman <eugene@titerman.com> --------- Co-authored-by: acrius <acrius@mail.ru> Co-authored-by: dbastrikin <dbastrikin@adapty.io> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: eandreeva-twr <eandreeva@adapty.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #822: merge after #822 and after the purchase and restore outcomes release.
What
Adds the behaviour of purchase and restore outcomes that #822 doesn't cover yet. It is checked against the builder and transformer code before release. #822 owns the setup; this PR adds only diagnosis and one preview limit, so it is stacked on that branch.
flow-common-issues: two new entries.The flow doesn't run the actions set for a purchase result. Outcome actions run only while the user stays on the screen where the purchase started. The causes, each with a fix:
AdaptyFlowEventListenerfor the flow, or one of its callbacks throws.The entry also says that the Adapty mobile app preview runs only the success outcomes.
A Purchase button does nothing on Android. On Android, a tap before Google Play returns the products does nothing, and the button works once the products load. On iOS, the same early tap fails the purchase, so When failed runs. Includes a fix for a product that never loads.
paywall-device-compatibility-preview, Preview on devices: one paragraph. In the preview, every purchase and restoration succeeds, so only When succeeded and When restore completed run.respond-to-purchase-outcomes: next to "make a sandbox purchase", the same preview limit and a link to the new troubleshooting entry. This links prevention in setup with diagnosis in troubleshooting, in both directions.flow-logiczone brief:Why
Two kinds of reports come up once the feature ships:
Without these entries the reader has no place to diagnose either.
Verification
editorskill's review pass order over the added lines;lint-prosecandidates on the added lines reviewed.lint-mdx,check-mdx-parseandcheck-links-diffpass (no broken or stale links in or to the changed files);npm testpasses, including the context-mill anonymity test.Not covered
Needs confirmation before merge. The preview claim ("every purchase and restoration succeeds") rests on the iOS SDK developer tools (
AdaptySDK-iOS4.2.2,Sources.DeveloperTools/AdaptyUI/Dev_AdaptyUILogic.swift: purchase, restore and web purchase all answer success after 1.5 s). It is not verified against the Adapty mobile app itself, and not checked for its Android version. If either app behaves differently, narrow the three sentences. The brief records this as an open question.Left out as edge cases:
The brief records all four.
No screenshots. One would help in the troubleshooting entry: the warning under the actions ("Navigation or Close Flow after a purchase or restore runs right away, before the result…").
Shipped skills: no ripple. Only
flow-common-issuesis cited by a skill, and the change adds sections without restating a fact a skill copies.Notes on post-purchase branching + updated funnels #822 found while checking it against the code (not changed here):
onboarding-actions: two lines say In-app store (the option bullet and the follow-up sentence), but the builder label is In-App Store.respond-to-purchase-outcomesalready uses In-App Store.flows-with-your-own-payments: "After a purchase restoration, the flow runs the When restore completed actions, whatever happened" is not confirmed from code here. See also the review note ononFinishRestore.respond-to-purchase-outcomes, Before you start: the order "your app's callbacks run before them" is not verified per platform.🤖 Generated with Claude Code