Repository navigation
Mail: campaign content locks once the campaign is in a flow - #891
Draft
eandreeva-twr wants to merge 1 commit into
Draft
eandreeva-twr wants to merge 1 commit into
eandreeva-twr wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kind: stale finding.
What changed in the product. Adapty Mail now locks a campaign's content once the campaign leaves draft, that is, once it is added to a flow. In a live or inactive campaign, the emails (subject, HTML, plain text, image, delay), the languages and the Email Destination can no longer change; the name and description still can. The editor shows: "This campaign has been used in a flow, so its content cannot be edited. Duplicate the campaign and put the copy into the flow." A test send and the spam check still work.
Doc text that became wrong.
mail-flows, Flow lifecycle: "Campaign edits reach users already in the flow. Adapty Mail reads the copy of each email at send time, and its Delay when the previous email is delivered." and "The text of a translation only changes when you update the translation and save the campaign." Replaced with one bullet: only name and description change after a campaign is in a flow; to change content, duplicate, edit the copy, and add it to the flow.mail-flows, Email delivery timing: delays are editable "in the campaign editor" — now scoped to drafts.mail-localization, Remove translations: "To make these changes, update any Outdated translations and save the campaign. Then duplicate it…" — updating translations of a live campaign is now refused. Rewritten to the same duplicate-and-edit path.mail-create-campaign: "To try a different one, reopen the campaign and generate again" — scoped to a draft, plus one sentence after the status list linking tomail-flows#flow-lifecycle.Assumptions recorded.