Skip to content

ci: keep Dependabot off the frozen Python interop pins and the codegen pin - #1650

Merged
bokelley merged 1 commit into
mainfrom
claude/issue-1634-dependabot-ignore-frozen-pins
Oct 27, 2026
Merged

bokelley merged 1 commit into
mainfrom
claude/issue-1634-dependabot-ignore-frozen-pins

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Dependabot security updates opened #1634, which repeats the deferred #1538. It does two things this repo doesn't want:

  • It bumps the exact datamodel-code-generator pin from 0.64.0 to 0.81.0 without regenerating anything. The pin is exact because the generator's class numbering shifts between releases. An upgrade has to regenerate src/adcp/types/ in the same change, and that's a deliberate SDK 10 decision (docs/v10-codegen-plan.md in docs(types): plan the SDK 10 codegen fidelity and wire round-trip work #1649, against next). The generator is a dev-only tool and isn't shipped in the wheel.
  • It edits scripts/ci/reporting_interop/python/requirements-*.txt. Each file pins the installed environment that one reporting interop control verifies, so changing it breaks the control (5 failing checks on chore(deps): bump the pip group across 2 directories with 4 updates #1634) and fixes nothing in a shipped artifact.

This extends .github/dependabot.yml (added in #1590 for the npm interop lockfiles):

  • pip, /scripts/ci/reporting_interop/python: ignores every dependency, like the npm entry.
  • pip and uv, /: ignores datamodel-code-generator. Dependabot filed the root manifest as pip; uv.lock makes it a uv project too, so both ecosystems carry the rule.

Every entry keeps open-pull-requests-limit: 0, so no version-update PRs start. Ignore rules also apply to security updates. Every other root dependency still gets security updates as before.

#1634 will be closed with a comment pointing here.

🤖 Generated with Claude Code

…n pin

#1634 repeats the deferred #1538. It bumps the exact
datamodel-code-generator pin (0.64 -> 0.81) without regenerating
src/adcp/types/, and edits the frozen reporting interop requirement files
under scripts/ci/reporting_interop/python/, which breaks those controls.

Add a pip entry for the interop directory that ignores every dependency,
matching the npm entry from #1590, and pip and uv entries for the root that
ignore datamodel-code-generator. Version updates stay off
(open-pull-requests-limit: 0); ignore rules also apply to security updates.
Generator upgrades are an SDK 10 decision (docs/v10-codegen-plan.md, #1649).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean single-file CI change to .github/dependabot.yml (+33).

Checked:

  • No findings at critical/high/medium severity.
  • Not a gated path (gated_paths: false), not high-risk, no author team gate.
  • Change adds a pip entry ignoring deps in the frozen interop dir, plus pip/uv root entries ignoring datamodel-code-generator. YAML and ecosystem values are valid; open-pull-requests-limit: 0 plus the ignore rules correctly suppress security updates for the codegen pin while leaving other root deps covered.
  • One non-blocking note: the uv entry's rationale cites uv.lock, which is gitignored and not committed, so that entry is harmless defensive config (no-op until a lockfile lands). Not blocking.

No decision-table trigger fired (rows 1–8 all false), so this falls through to row 9.

@bokelley
bokelley merged commit dad3282 into main Oct 27, 2026
83 of 84 checks passed
@bokelley
bokelley deleted the claude/issue-1634-dependabot-ignore-frozen-pins branch October 27, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant