Repository navigation
feat(examples): serve the AdCP 3.3 property breakdowns from injected rows in the reference seller - #1715
Merged
Conversation
…rows in the reference seller The 3.3 storyboards property_delivery_reporting and installment_property_delivery_reporting grade not_applicable against the reference seller: it declared neither seller-wide rollup and its simulate_delivery accepted no injected rows. The reference seller now declares media_buy.features supports_property_breakdown and supports_installment_property_breakdown. simulate_delivery accepts property_delivery and installment_property_delivery on a single-package buy; each array replaces the previous one and never enters totals. get_media_buy_delivery returns by_property and by_installment_property from exactly those rows for products with the matching reporting flag, sorted before the limit, with the truncated, suppressed, sorted_by and sort_direction companions. Refs #1669 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean example-only PR.
Changes touch examples/seller_agent.py and tests/test_seller_agent_storyboard.py only — not the public adcp.* surface. Adds AdCP 3.3 property / installment_property breakdowns to the reference seller agent plus storyboard tests.
Checked:
- No public-API / wire-shape changes, so no semver signal required;
feat(examples):prefix is correct. _injected_breakdownsorts-then-limits with_truncated/_suppressed/_sorted_by/_sort_directioncompanions, mirroring the existingby_formatpattern; deepcopy guards row mutation.- Single-package guard keeps media-buy-level
injected_deliveryunambiguous; serving gated on both agent feature flag and productreporting_capabilitiesflag. - Tests validate the full response against the real 3.3.0-beta.1 schema, cover both sort directions and the multi-package refusal.
No Critical/High/Medium findings. high_risk false, gated_paths false, no author team gate. Falls through to row 9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1669. The 3.3 storyboards
media_buy_seller/property_delivery_reportingandinstallment_property_delivery_reportinggraded not_applicable againstexamples/seller_agent.py: it declared neither seller-wide rollup, and itssimulate_deliveryaccepted no injected rows. After this PR it declares both, so the storyboard CI lanes run them.media_buy.features.supports_property_breakdownandsupports_installment_property_breakdownare nowtrue.simulate_delivery: acceptsproperty_deliveryandinstallment_property_deliveryon a single-package buy and refuses a multi-package buy withINVALID_PARAMS. Each array replaces the previous one and never enters totals. The SDK dispatcher, as of feat(reporting): apply the AdCP 3.3 reporting rules #1707, already refuses these arrays when sent withdelivery_date.get_media_buy_delivery: for products with the matching reporting flag,reporting_dimensions.property/installment_propertyreturnby_property/by_installment_propertyfrom exactly the injected rows. Rows are sorted before the limit is applied, with the_truncated,_suppressed(false),_sorted_byand_sort_directioncompanions.Tests: a parametrized test mirrors both storyboards' row sets, limits and orderings, and validates against the 3.3.0-beta.1 delivery response schema; another covers the multi-package refusal.
test_seller_agent_storyboard.py,test_seller_agent_dual_emit.pyandtest_discovery_payload_size.py: 78 passed.Refs #1669
🤖 Generated with Claude Code