Repository navigation
docs(conversion): list the playback pixel tracker rewrite in the 3.3 to 3.2 rules (#1643) - #1814
Merged
Merged
Conversation
…to 3.2 rules (#1643) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![aao-secretariat[bot]](https://avatars.githubusercontent.com/u/221690821?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — docs-only change, no blocking findings.
This PR touches a single file (docs/cross-version-conversion.md, +4/-2) documenting the playback pixel-tracker rewrite in the 3.3→3.2 and 3.0 rules. The reviewer verified every claim against the implementation: the new playback_event_as_custom row matches _playback_tracker_as_custom and its loss record in compat/versions.py, and the 3.0 prose matches downgrade_pixel_tracker in canonical_formats/pixel_tracker.py. No wire shape, public export, or generated code touched.
No findings of any severity. high_risk is false, gated_paths is false, no author-team gate, no prior decision. None of decision rows 1–8 fire, so this falls through to row 9 → approve.
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1800. The "3.3 → 3.2 semantic rules" table in
docs/cross-version-conversion.mdsaid playback pixel trackers "have their own rules" without stating them. This adds the row: astart/first_quartile/midpoint/third_quartile/completetracker becomesevent: customwithcustom_event_name, recorded asplayback_event_as_custom. It also notes that the 3.0tracker_pixelshape drops these trackers, including thecustomform. Docs only.Refs #1643
🤖 Generated with Claude Code