Skip to content

docs(reporting-storage): say adcp 10.0.0b4 and b5 still install beside storage 0.2.0b0 - #1840

Open
bokelley wants to merge 1 commit into
nextfrom
claude/issue-1837-contract-refusal-docs
Open

bokelley wants to merge 1 commit into
nextfrom
claude/issue-1837-contract-refusal-docs

Conversation

@bokelley

@bokelley bokelley commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Docs half of #1837. This PR doesn't yank anything on PyPI; that decision is still open on the issue.

The contract check that refuses a storage package of another contract (#1789) first ships in adcp 10.0.0b7. adcp 10.0.0b4 and 10.0.0b5 are on PyPI, unyanked, and predate it. Storage 0.2.0b0 allows adcp>=9.0.0,<11, so adcp==10.0.0b5 with adcp-reporting-storage==0.2.0b0 still resolves, and that pair fails every reporting turn with column "offering_id" does not exist. I confirmed the check's first release from tags: storage_contract.py is absent at v10.0.0-beta.5 and present at v10.0.0-beta.7. 10.0.0b6 was never published.

Changes:

  • docs/reporting-ledger-migration.md. It said "From 0.2.0b1 the pair is refused at startup". It now says adcp 10.0.0b7+ refuses the pair, that b4/b5 don't, and to install adcp>=10.0.0b7 with storage >=0.2.0b1.
  • packages/adcp-reporting-storage/README.md. "If one is forced, building a PostgreSQL store refuses at startup" was wrong in two ways. Forcing storage 0.2.0b1 onto adcp ≤ 10.0.0b3 fails at import (_CONFIGURATION_COLUMNS) before the check runs. And the check is in adcp, so it can't cover adcp releases that predate it. This adds the b4/b5 caveat and a 0.2.0b0 row note to the compatibility table.
  • MIGRATION_v9_to_v10.md. The startup-refusal bullet now names 10.0.0b7 and the b4/b5 gap.

Docs only: no code, schema or test changes.

Refs #1837. I left the issue open for the yank decision: adcp 10.0.0b4/b5, storage 0.2.0b0, or neither.

🤖 Generated with Claude Code

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — docs-only correction with no findings.

This PR touches 3 markdown files (MIGRATION_v9_to_v10.md, docs/reporting-ledger-migration.md, packages/adcp-reporting-storage/README.md), correcting which adcp release refuses an incompatible reporting-storage pair (24 additions / 10 deletions, ≤12 lines each). The reviewer verified every version claim against the code: the storage contract declaration (REPORTING_STORAGE_CONTRACT=2, first published b7), the b4/b5 column-inspection classification resolving beside 0.2.0b0 with no refusal, and the top-level _CONFIGURATION_COLUMNS import at pg.py:97 confirming the "fails at import" claim for ≤b3. No wire/semver/public-surface change, no generated code, no operational paths.

Decision table: no critical/high/medium findings (rows 1, 4–6, 8 don't fire); gated_paths is false (row 2 n/a); high_risk is false (rows 3, 5 n/a); no prior decision (row 6 n/a); no no-auto-approve team match (row 7 n/a). Falls through to row 9 → approve.

…e storage 0.2.0b0

The contract check that refuses a storage package of another contract
ships in adcp 10.0.0b7. adcp 10.0.0b4 and 10.0.0b5 predate it and still
resolve beside adcp-reporting-storage 0.2.0b0, and that pair fails every
reporting turn with `column "offering_id" does not exist`. The migration
guide, the storage README and MIGRATION_v9_to_v10.md said the pair is
refused at startup from 0.2.0b1. Name the adcp release that refuses it,
say which releases don't, and point to adcp>=10.0.0b7.

The README also said a forced pair "refuses at startup". With adcp
10.0.0b3 or earlier it fails at import instead, before the check runs.

Refs #1837

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bokelley
bokelley force-pushed the claude/issue-1837-contract-refusal-docs branch from c8ed53c to 34762a1 Compare November 3, 2026 16:33

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — docs-only migration/compat correction, no findings.

This PR touches three Markdown files (MIGRATION_v9_to_v10.md, docs/reporting-ledger-migration.md, packages/adcp-reporting-storage/README.md) to correct version-compatibility claims: the storage-contract check first ships in adcp 10.0.0b7; 10.0.0b4/b5 predate it and still resolve beside adcp-reporting-storage 0.2.0b0 (failing with column "offering_id" does not exist); and forcing 0.2.0b1 onto older adcp fails at import. The reviewer verified the referenced symbols (storage_contract, REPORTING_STORAGE_CONTRACT, REPORTING_SCHEMA_BEHIND) exist and that the three files are internally consistent with the tag-verified claims in the PR body.

Gate checks:

  • No critical/high/medium findings (row 1, 4, 5, 8 not triggered).
  • gated_paths: false; review_decision: APPROVED (row 2 n/a).
  • high_risk: false, no deletions (rows 3, 5 n/a).
  • No no-auto-approve team match (row 7 n/a).
  • Prior decision was approve, not escalate (row 6 n/a).

No code, schema, or test touched. Falls through to row 9 → approve.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant