Repository navigation
fix(storyboard): skip observations after unsupported forcing - #3561
Merged
Merged
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean diff, no blocking or medium findings.
Checked:
- Storyboard runner now cascades a neutral coverage skip when a stateful
force_scenario_unsupportedcontroller step cannot establish forced state, bypassing the sole-stateful-step exemption and propagating across non-routed dependency hops. All four runner.ts changes (CascadeTrigger doc, inherited-capability propagation, immediate force cascade, missing_tool/not_applicable precedence) traced against cascadeForPhase and the real-failure path; precedence ordering (real failure > real missing-state > capability-only) preserved. - +165-line test file exercises every new branch (three layouts, independent phase, non-stateful force, success/wrong-outcome, real failure, both deferred-setup precedence cases).
- Changeset present and correctly typed
patch— no export or response-shape change, consistent with the diff. - Witness-not-translator: no fabrication, no re-shaping at a seam.
No no-auto-approve team match; gated_paths false; high_risk false. Although review_decision is REVIEW_REQUIRED, row 2 only applies when gated_paths is true (it is false here), so the PR falls through to row 9 — approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A seller returning
UNKNOWN_SCENARIOfor optional controller forcing was skipped correctly, but dependent observations still ran without the forced state and falsely failed. Stateful unsupported forcing now skips those observations as unavailable coverage, including same-phase observations and explicit chains of dependent phases.Independent phases, ordinary account-setup exemptions, peer substitutions and genuine failures retain their grading. Deferred missing-state failures take precedence over unavailable forcing. Skipped observations receive no executed-step or validation credit.
Refs #3549. The runner-contract clarification is adcp #8642.
Validation
get_products_rejectedstoryboard: unsupported forcing dispatches noget_products; successful forcing runs both steps and passes.CI interop receipts: current-checkout TypeScript (14 executed passes), strict 3.0 (2), and Python (56) pass. The advisory external TypeScript catalog-capture failure and Go version/capability failures have identical failing steps/checks to the pre-fix run 41173484692; these lanes are not claimed as fully conformant.