Repository navigation
fix(ci): repair main after the beta.3 adoption and creative package-fit merges - #3565
Merged
Merged
Conversation
…it merges #3559/#3560 (AdCP 3.3.0-beta.3) and #3564 (creative package-fit decisions) landed in parallel. #3564's test pinned adcpVersion 3.3.0-beta.2, which the SDK no longer bundles, and its published guide put the package one file over #3559's exact file-count budget. Read ADCP_VERSION in the test, count the guide, and raise the packed cap to cover the combined size plus the release PR's CHANGELOG growth. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean CI/test-only repair of main after parallel merges (#3559/#3560 beta.3, #3564 package-fit).
Checked:
- Changeset (
.changeset/fix-main-beta3-merge.md): empty changeset is correct — nosrc/lib/**,bin/**, build-affectingscripts/**, or publishedfilespaths touched. Only a CI helper script and a test changed, so no version bump is warranted. - Test (
test/lib/creative-package-fit.test.js): swaps stale'3.3.0-beta.2'pin for the exportedADCP_VERSION(baseversion.ts:12='3.3.0-beta.3'), correctly tracking the only bundled preview. - Size budgets (
scripts/check-package-size.mjs): file count +1 forCREATIVE-PACKAGE-FIT.md; packed cap raised to 26,910,000 (~47 KB over measured 26,862,555). Internally consistent with the PR body.
No witness-not-translator, version-pathway, transport-client, or doc-link concerns. No Critical/High/Medium findings. gated_paths is false, high_risk is false, no author team gate. Rows 1–8 do not fire → row 9 approve. (review_decision: REVIEW_REQUIRED only blocks approve when gated_paths is true, which it is not here.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repairs
mainand the release PR #3550, which are both red after #3559 and #3560 (AdCP 3.3.0-beta.3) and #3564 (creative package-fit decisions) landed in parallel. This is a CI and test-only change, with an empty changeset.Root causes (from the job logs of #3550 run 41238743345 and main's CI)
not ok 281 - sync snapshots measured creative facts before capability discovery: feat(projection): expose creative package fit decisions #3564's new test (test/lib/creative-package-fit.test.js) pinnedadcpVersion: '3.3.0-beta.2'. Since feat: adopt signed AdCP 3.3.0-beta.3 and serve the reporting-subscription surface #3559 the SDK bundles only3.3.0-beta.3, so the client constructor throwsCONFIGURATION_ERROR. The test now readsADCP_VERSION.packed file count is 8529 files; budget is 8528 files. feat(projection): expose creative package fit decisions #3564 publishesdocs/guides/CREATIVE-PACKAGE-FIT.md, and feat: adopt signed AdCP 3.3.0-beta.3 and serve the reporting-subscription surface #3559 had set the file count to an exact total. The fix counts the guide (+1). The packed size is now 26,862,555 bytes against a 26,870,000 cap, which leaves 7 KB and would trip on the release PR's CHANGELOG. The cap goes to 26,910,000, with a comment.Main's own
ci.ymlis red on the same jobs (heads 71227f4 and 47e4f11). The last green main was 6fef3b8.Checks
check:package-sizepasses: 25.6 MiB packed (26,862,555 bytes) and 8,529 files.test/lib/creative-package-fit.test.js: 89 pass.🤖 Generated with Claude Code