Skip to content

fix(ci): repair main after the beta.3 adoption and creative package-fit merges - #3565

Merged
bokelley merged 1 commit into
mainfrom
bokelley/fix-main-beta3-merge
Oct 31, 2026
Merged

bokelley merged 1 commit into
mainfrom
bokelley/fix-main-beta3-merge

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Summary

This repairs main and the release PR #3550, which are both red after #3559 and #3560 (AdCP 3.3.0-beta.3) and #3564 (creative package-fit decisions) landed in parallel. This is a CI and test-only change, with an empty changeset.

Root causes (from the job logs of #3550 run 41238743345 and main's CI)

  1. Unit Tests Fast (2/3), not ok 281 - sync snapshots measured creative facts before capability discovery: feat(projection): expose creative package fit decisions #3564's new test (test/lib/creative-package-fit.test.js) pinned adcpVersion: '3.3.0-beta.2'. Since feat: adopt signed AdCP 3.3.0-beta.3 and serve the reporting-subscription surface #3559 the SDK bundles only 3.3.0-beta.3, so the client constructor throws CONFIGURATION_ERROR. The test now reads ADCP_VERSION.
  2. Library Package Checks, Package Artifact Smoke, and the three Node/Undici lanes all fail with packed file count is 8529 files; budget is 8528 files. feat(projection): expose creative package fit decisions #3564 publishes docs/guides/CREATIVE-PACKAGE-FIT.md, and feat: adopt signed AdCP 3.3.0-beta.3 and serve the reporting-subscription surface #3559 had set the file count to an exact total. The fix counts the guide (+1). The packed size is now 26,862,555 bytes against a 26,870,000 cap, which leaves 7 KB and would trip on the release PR's CHANGELOG. The cap goes to 26,910,000, with a comment.
  3. Test & Build, Unit Tests, and Typecheck & Build are summary jobs that fail because of the above.

Main's own ci.yml is red on the same jobs (heads 71227f4 and 47e4f11). The last green main was 6fef3b8.

Checks

  • check:package-size passes: 25.6 MiB packed (26,862,555 bytes) and 8,529 files.
  • test/lib/creative-package-fit.test.js: 89 pass.

🤖 Generated with Claude Code

…it merges

#3559/#3560 (AdCP 3.3.0-beta.3) and #3564 (creative package-fit decisions)
landed in parallel. #3564's test pinned adcpVersion 3.3.0-beta.2, which the SDK
no longer bundles, and its published guide put the package one file over
#3559's exact file-count budget. Read ADCP_VERSION in the test, count the guide,
and raise the packed cap to cover the combined size plus the release PR's
CHANGELOG growth.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean CI/test-only repair of main after parallel merges (#3559/#3560 beta.3, #3564 package-fit).

Checked:

  • Changeset (.changeset/fix-main-beta3-merge.md): empty changeset is correct — no src/lib/**, bin/**, build-affecting scripts/**, or published files paths touched. Only a CI helper script and a test changed, so no version bump is warranted.
  • Test (test/lib/creative-package-fit.test.js): swaps stale '3.3.0-beta.2' pin for the exported ADCP_VERSION (base version.ts:12 = '3.3.0-beta.3'), correctly tracking the only bundled preview.
  • Size budgets (scripts/check-package-size.mjs): file count +1 for CREATIVE-PACKAGE-FIT.md; packed cap raised to 26,910,000 (~47 KB over measured 26,862,555). Internally consistent with the PR body.

No witness-not-translator, version-pathway, transport-client, or doc-link concerns. No Critical/High/Medium findings. gated_paths is false, high_risk is false, no author team gate. Rows 1–8 do not fire → row 9 approve. (review_decision: REVIEW_REQUIRED only blocks approve when gated_paths is true, which it is not here.)

@bokelley
bokelley merged commit 9e7906d into main Oct 31, 2026
45 checks passed
@bokelley
bokelley deleted the bokelley/fix-main-beta3-merge branch October 31, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant