Repository navigation
feat(reporting): prior_versions carry configuration; sub-daily local periods restart at local midnight #8588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "adcontextprotocol": minor | ||
| --- | ||
|
|
||
| Reporting subscriptions (experimental): each `prior_versions` entry on the subscription readback now carries the `configuration` that version had (scope, selector, destination, `reconciliation_mode`), and sellers MUST include it. A buyer that lost local state can then recompute a prior version's owed periods; before, the readback said when a version was accepted and superseded but not what it covered. | ||
|
|
||
| Reporting schedules (experimental): fix sub-daily periods under a local alignment (`account_timezone`, `source_timezone`, `billing_cycle`). They were anchored to local midnight on 1970-01-01 plus elapsed hours, so hourly periods in Asia/Singapore ran 07:30–08:30 local (its 1970 offset was +07:30), Asia/Kathmandu hours started at :15, and America/New_York PT6H boundaries drifted an hour with DST. A sub-daily duration under a local alignment now MUST divide 24 hours, and its boundaries are local wall-clock multiples counted afresh from each local midnight. A 23-hour DST day has 23 hourly periods and a 25-hour day 25; a nonexistent wall time yields no boundary, and a repeated one yields one per offset. Durations under a local alignment cannot mix date and time components. `utc` alignment is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Medium: The description says "Sellers MUST include it," but
configurationis not added to theprior_versions.items.requiredarray (still["subscription_version", "accepted_at", "superseded_at"]). The MUST is unenforced: a seller that omits it emits a schema-valid readback that defeats this field's stated purpose — recomputing a prior version's owed periods after local-state loss. Note the file's own top-levelconfiguration(L122) is inrequired; the nested entry is the inconsistent sibling. Addconfigurationto the items'requiredlist.