Skip to content

ci(schemas): generate the Python SDK from its next branch for 3.3 bundles - #8636

Merged
bokelley merged 1 commit into
mainfrom
bokelley/schema-bundle-python-next
Oct 31, 2026
Merged

bokelley merged 1 commit into
mainfrom
bokelley/schema-bundle-python-next

Conversation

@bokelley

@bokelley bokelley commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

The schema-bundle workflow used the Python SDK's default main branch, which remains the SDK 9 / AdCP 3.2 line and lacks the composed-envelope generation fixes. Main-branch protocol bundles are 3.3 candidates, so the Python generation job now checks out the SDK's next branch, the SDK 10 / AdCP 3.3 line.

Candidate provenance/checksum verification, historical schema caches, regeneration, generated-code validation and schema-pin tests retain their existing checks. Move the checkout back to the default branch when the SDK promotes 3.3 there.

Validation at fbcdcc945eda66c22ebcc58a8eafe36c321637c2:

  • All CI checks pass, including Generate Python SDK and Generate TypeScript SDK.
  • Build/static checks and the TypeScript aggregate pass after incorporating main's dependency security fix.
  • The change is operational CI configuration and needs no protocol changeset.

Automatic review found no blocking code findings but requires human approval for the gated .github/workflows/** path.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Escalate to human review

Escalate — gated path requires human/CODEOWNERS approval.

This PR modifies .github/workflows/validate-schema-bundle.yml, which matches the .github/workflows/** gated-paths glob (gated_paths: true). The current review_decision is REVIEW_REQUIRED, not APPROVED, so the hard approval gate (decision row 2) is not satisfied and the PR cannot be auto-approved.

The change itself is clean: a one-line CI fix setting ref: next on the adcp-client-python checkout so main-PR schema bundles (AdCP 3.3 candidates) generate against the SDK 3.3/next line instead of the 9.x/3.2 default branch. Operational-only — no protocol surface touched, no changeset required, no Critical/High/Medium findings. The workflow self-validates on this PR.

Despite the clean diff, the gated workflow path requires explicit human/CODEOWNERS review before merge.

Escalation reasons:

  • .github/workflows/validate-schema-bundle.yml is under a hard approval gate (.github/workflows/**); review_decision is REVIEW_REQUIRED — human/CODEOWNERS approval required.

Why human review

  • Modifies .github/workflows/validate-schema-bundle.yml, a gated path (.github/workflows/**), and review_decision is REVIEW_REQUIRED — human/CODEOWNERS approval required before merge.
  • This PR touches a path under a hard, non-overridable approval gate (.github/workflows/validate-schema-bundle.yml (modified) matches .github/workflows/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.

…dles

The Validate schema PR bundle workflow only runs for PRs to main, whose
bundles are AdCP 3.3 candidates. The Python SDK's default branch is the 9.x
line for AdCP 3.2; 3.3 bundles generate only on its next branch (SDK 10).
Check out next explicitly.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@bokelley
bokelley force-pushed the bokelley/schema-bundle-python-next branch from fbcdcc9 to bf4184c Compare October 31, 2026 04:30

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Escalate to human review

Escalate — gated path requires human/CODEOWNERS approval.

This PR modifies .github/workflows/validate-schema-bundle.yml, which matches the hard, path-based approval gate .github/workflows/** (gated_paths: true), and the current review_decision is REVIEW_REQUIRED, not APPROVED. Per decision rule row 2, the outcome must be escalate until a real human/CODEOWNERS approval is recorded — regardless of how clean the diff is.

The reviewer returned a clean pass with no Critical/High/Medium findings: the single CI-config change points the Python SDK generation job at the SDK's next branch (SDK 10 / AdCP 3.3) to fix the 3.3 bundle-key mismatch, with no protocol surface touched and provenance/checksum verification untouched. This is consistent with the prior escalate, which was purely gate-driven with no actionable findings.

Escalation reasons

  • .github/workflows/validate-schema-bundle.yml (modified) matches gated path .github/workflows/** and review_decision is REVIEW_REQUIRED — human/CODEOWNERS approval required before merge.

Why human review

  • Modifies .github/workflows/validate-schema-bundle.yml, a gated path (.github/workflows/**), and review_decision is REVIEW_REQUIRED, not APPROVED — human/CODEOWNERS approval required before merge.
  • This PR touches a path under a hard, non-overridable approval gate (.github/workflows/validate-schema-bundle.yml (modified) matches .github/workflows/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.

Copy link
Copy Markdown
Contributor Author

"Generate Python SDK" now checks out next and gets through packaging and generation; the first run on this branch passed end to end. Since the beta.3 schema PRs merged (#8617 to #8620), it fails at SDK import: _patch_targeting_overlay in src/adcp/types/_forward_compat.py finds PackageRequest.targeting_overlay already wrapped (Annotated[TargetingOverlayInput | SkipJsonSchema[TargetingOverlay] | None, ...]) and raises. That means the patch is applied twice: an SDK-side forward-compat issue for the Python maintainers to triage, not a branch-selection problem. Ladon found nothing; it escalated only because .github/workflows/** is gated. Merging by admin as instructed.

@bokelley
bokelley merged commit dfd94e7 into main Oct 31, 2026
32 of 34 checks passed
@bokelley
bokelley deleted the bokelley/schema-bundle-python-next branch October 31, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ladon/needs-human-review Ladon has escalated this PR for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant