Repository navigation
docs(reference): curated 3.3.0-beta.3 notes - #8640
Conversation
There was a problem hiding this comment.
Ladon verdict: Request changes
Request changes — 1 blocking finding.
Blocking findings
- docs/reference/whats-new-in-3-3.mdx:29 — beta.3 notes describe unmerged #8620 account-request wire behavior as shipped, including a normative "now fail validation" adopter claim, but #8620 is OPEN and its schema is on an unmerged branch. This is spec drift (docs asserting a wire shape the merged schema does not yet encode).
Medium findings
- docs/reference/whats-new-in-3-3.mdx:42 — Test-assets bullet cites unmerged #8621 (reporting_subscription_probe) as shipped; #8621 is also OPEN.
This is an editorial docs-only aggregation of 3.3.0-beta.3 notes. The reviewer verified nearly every cited field and error code against static/schemas/source and confirmed the backing PRs are merged — except #8620 and #8621, both of which are still OPEN. The notes present their behavior as already shipped. Both backing PRs must land before/with these notes, or the claims must be removed/deferred. Per the schema↔docs coherence rule, docs asserting a wire shape the schema does not encode is high. Row 1 of the decision table (a high finding present) → request-changes.
Blocking findings
- docs/reference/whats-new-in-3-3.mdx:29 — beta.3 notes describe unmerged #8620 wire behavior as shipped (spec drift); #8620 is OPEN on an unmerged branch
Medium findings
- docs/reference/whats-new-in-3-3.mdx:42 — Test-assets bullet cites unmerged #8621 (reporting_subscription_probe) as shipped
What's new in 3.3 gains a "New in beta.3" section: account change outcomes and opt-in, money terms on resolved requests, revocation meaning no access with the reduced-grant wind-down and partial grants, and the reporting subscription convergence (owed confirmation period, inactive coverage, billing stubs, wire data, determinism, scale, period arithmetic, vectors, and the controller probe), plus live creative updates. The adopter-attention table and the beta program's merged-so-far columns are updated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
b1d7761 to
6c418c0
Compare
Superseded by a later Ladon review that rechecked and resolved its blocking findings.
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — docs-only beta.3 release-notes aggregation (3 files, +32/-3).
Prior HIGH blocker is RESOLVED: whats-new-in-3-3.mdx #8620 account-request wire behavior is now merged into base (commit 4af25bf). Reviewer verified all other cited PRs are merged (#8580/8582/8585/8588/8593/8596/8607/8613/8616/8617/8618/8619/8622/8488). Net improvement over the prior request-changes run.
Medium findings
- docs/reference/whats-new-in-3-3.mdx:41 — Test-assets bullet cites unmerged #8621 (reporting_subscription_probe) as shipped
Decision rationale: No critical/high findings (row 1 clears). gated_paths is false (row 2 n/a). high_risk is true but all reasons are (modified) docs pages; the sole medium finding is not in data-loss/schema/infra category (rows 4/5 n/a — row 5 requires a high-risk-path medium, which this doc medium would technically match... but the category is docs/spec-drift-adjacent, not an escalation category). Reconsidering row 5: high_risk true + (modified) + a medium finding present — this DOES match row 5.
Medium findings
- docs/reference/whats-new-in-3-3.mdx:41 — Test-assets bullet cites unmerged #8621 (reporting_subscription_probe) as shipped
Summary
Curated notes for 3.3.0-beta.3 in
docs/reference/whats-new-in-3-3.mdx, in a new New in beta.3 section:allow_separate_accountopt-in (first shipped in beta.2),accountwith money terms now required onmatchedandcreated(adopter action),effective_at,not_carried_over, and timezone/currency changeability (feat(accounts): change outcomes, visible sync_accounts reviews, countries semantics (beta.1 feedback) #8580, feat(accounts): opt-in separate account on a change; ACCOUNT_CHANGE_REQUIRES_NEW_ACCOUNT #8582, feat(accounts): money terms on resolved account requests; consistent timezone changes #8620).Also:
Docs only; no changeset needed.
Test plan
🤖 Generated with Claude Code