Repository navigation
Conversation
Three additive enum values on core/requirements/video-asset-requirements.json containers. lint:additive-minor reports 0 new. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #8107. Proposed to ship in 3.3 by consent; objections by Fri 2026-11-06. Do not merge before Nov 6.
Change
core/requirements/video-asset-requirements.json:containersgains3gp,mpegandm4v. The description says they were added in 3.3 and thatmpegis an MPEG-1/2 program stream (video/mpeg), not a transport stream (the VAST schema'smpeg_ts).docs/reference/3-3-beta.mdx: the Proposal (3.3): add 3gp, mpeg and m4v to video containers #8107 row now names the change.tests/x-added-in-3-3-sweep.test.cjs, following themxfprecedent from feat(schema): add NMO and VideoAmp demographic systems, MXF and loudness on video_hosted #8019.Additive check
The
containersitems enum is closed, but only on its value list. The requirements object itself keepsadditionalProperties: true.scripts/lint-additive-minor.cjsflags removed enum values, not added ones, andversioning.mdxtreats enum additions as additive (clients must tolerate unknown values).npm run lint:additive-minor: 0 new. A strict 3.2 validator would reject a seller that lists a new value, which is the same cost asmxfin #8019.Not in this PR
video_hostedcontainers(mp4,webm,mov,mxf) and the open pattern invast-media-file-requirements.jsonare unchanged. The issue'svideo_hostedquestion has no maintainer ruling yet.Testing
lint:additive-minor,tests/schema-validation.test.cjs(36/36),x-added-in-3-3-sweep(6/6), changeset scope check andchangesets status: pass. Committed with hooks disabled (HUSKY=0); CI is the full check.🤖 Generated with Claude Code
Open workspace in Conductor