Skip to content

feat(schema): add 3gp, mpeg and m4v to video containers (#8107) - #8668

Draft
bokelley wants to merge 1 commit into
mainfrom
consent/video-containers-3gp-mpeg-m4v
Draft

bokelley wants to merge 1 commit into
mainfrom
consent/video-containers-3gp-mpeg-m4v

Conversation

@bokelley

@bokelley bokelley commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Refs #8107. Proposed to ship in 3.3 by consent; objections by Fri 2026-11-06. Do not merge before Nov 6.

Change

Additive check

The containers items enum is closed, but only on its value list. The requirements object itself keeps additionalProperties: true. scripts/lint-additive-minor.cjs flags removed enum values, not added ones, and versioning.mdx treats enum additions as additive (clients must tolerate unknown values). npm run lint:additive-minor: 0 new. A strict 3.2 validator would reject a seller that lists a new value, which is the same cost as mxf in #8019.

Not in this PR

video_hosted containers (mp4, webm, mov, mxf) and the open pattern in vast-media-file-requirements.json are unchanged. The issue's video_hosted question has no maintainer ruling yet.

Testing

lint:additive-minor, tests/schema-validation.test.cjs (36/36), x-added-in-3-3-sweep (6/6), changeset scope check and changesets status: pass. Committed with hooks disabled (HUSKY=0); CI is the full check.

🤖 Generated with Claude Code


Open workspace in Conductor

Three additive enum values on core/requirements/video-asset-requirements.json containers. lint:additive-minor reports 0 new.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant