Repository navigation
Drop the Node engines field so npx runs are not blocked by version checks - #73
Merged
Merged
Conversation
…ecks Packref runs mostly through npx, and the engines field only served development. The README now states Node.js 22 or later as the supported floor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
ℹ️ One documentation correction: dependency engine checks still apply.
Reviewed changes I reviewed the package metadata, README, and changeset, and verified the packed CLI with pnpm run build:verify.
- Package metadata: Removes Packref's
engines.nodedeclaration without changing dependencies or runtime code. - Supported versions: Adds a Node.js 22-or-later statement to the README.
- Release note: Adds a patch changeset for the removal of Packref's version check.
gpt-6.1-sol | 𝕏
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes I reviewed the documentation changes in f9772d5 since the prior Pullfrog review.
- Limited the release claim: Clarified that this change removes only Packref's own
engines.nodedeclaration and that dependency engine checks still apply. - Corrected the supported version: Changed the README minimum to Node.js 22.19, which matches the current dependency requirement.
The dependency lockfile confirms that undici@8.11.2 requires Node.js >=22.19.0. The current CI build, check, analyze, unit, and integration checks passed. I did not repeat local runtime tests for these documentation changes.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Most people run Packref with
npx. Theengines.node: ">=22"field did not help them. It only made npm warn, or fail withengine-strict, on Node versions where the CLI works. Development already gets its Node version from.node-version. This PR removes the field. The README now says that Packref supports Node.js 22.19 or later. npm still checks dependency engines, andundici@8(from@effect/platform-node) requires>=22.19.0.Why Node 22.19 and not lower
I ran the built CLI against the registry on several Node versions:
node:utildoes not exportstyleText(needed by@clack/prompts)add,list,remove,install,syncworkThe real floor is 20.12. But Node 20 is end-of-life, and a dependency update could break it with no warning. Node 22 is the oldest LTS that still gets support. Packref does not load
undiciat runtime because it usesNodeHttpClient.layerFetch. But withengine-strict=true, npm refuses to install on Node versions below 22.19, so the README states 22.19.The
tsdownoutput is byte-for-byte the same with and without theenginesfield.Merge danger
Changes made by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code