Skip to content

FORMS-26630: Add Terms and Conditons component in headless - #184

Merged
armaang1729 merged 6 commits into
mainfrom
tnc-copy
Aug 25, 2026
Merged

armaang1729 merged 6 commits into
mainfrom
tnc-copy

Conversation

@akshayvas

Copy link
Copy Markdown
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@akshayvas

Copy link
Copy Markdown
Contributor Author

@armaang1729 Please review. I have Raised PR using branch of main repo.

Implementation Screenshots below. There is one difference between Core components and headless - padding in terms and conditions text container. It is so because richText function(used in plain-text component) is adding a span on its own, whereas core components uses a div in plaintext instead. I will raise a separate PR for proposed changes in richtext utility and if required, its consumers, to address the issue.

disabled-for-popup link link-in-popup plain-checked popup

@armaang1729
armaang1729 requested a review from amit-mnnit August 25, 2026 04:41
@armaang1729

Copy link
Copy Markdown
Collaborator

The forms-components-examples/components/form/termsandconditions type (emitted by the dev AEM instance) isn't registered in the component mappings, so getRenderer falls back to the generic Panel — meaning TermsAndConditions never renders, IntersectionObserver never runs, and the checkbox stays disabled forever.

Added the alias in examples/basic-react-apps/src/utils/mappings.ts following the same pattern already used for verticaltabs and panelcontainer.

@armaang1729 armaang1729 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please help resolve the review comments @akshayvas ?

@armaang1729
armaang1729 merged commit 22460a7 into main Aug 25, 2026
3 checks passed
@armaang1729

Copy link
Copy Markdown
Collaborator

LGTM, Thanks !

@armaang1729
armaang1729 deleted the tnc-copy branch August 25, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants