Repository navigation
fix(html2json): preserve numeric-looking string codes verbatim - #9
Merged
Merged
Conversation
mhaack
approved these changes
Jun 23, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 23, 2026
## [0.1.2](v0.1.1...v0.1.2) (2026-06-23) ### Bug Fixes * **html2json:** preserve numeric-looking string codes verbatim ([#9](#9)) ([789bcf4](789bcf4))
|
🎉 This PR is included in version 0.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
String values that look like numbers were silently coerced to numbers during HTML→JSON conversion, corrupting opaque codes. E.g.
"710E-3"(valid scientific notation) became0.71.Cause
getNumber()usedNumber(text), which accepts forms that don't round-trip:710E-3→0.710xFF→255007→7Fix
Only coerce when the text is already the number's canonical form (
String(num) === text). Anything else is kept as a string. Genuine numbers like25,99.99,-5are unaffected.Tests
Added regression tests covering non-canonical numeric strings, numeric-looking list items, and canonical numbers (incl. negatives).
Checklist: