Repository navigation
fix(ui): use theme-aware styles for landing links - #294
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #249. Apply the existing Spectrum link style to the three unstyled inline links on the landing page, and load the focus-ring polyfill already used by the tool pages so keyboard focus gets Spectrum's double underline.
Motivation
The npm link measured 1.85:1 against the dark background. It now measures 5.21:1 in dark mode and 5.26:1 in light mode, with no new color overrides.
Checked all three links in default, hover and keyboard-focus states on the production build. Scoped ESLint and
vite buildpass; the existing unused-import and bundle-size warnings also occur before this change.To-do list