Repository navigation
fix(ui): preserve lightness stops in shared theme URLs - #295
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #252. Store the authored lightness stops alongside the contrast ratios in shared theme URLs, and restore them when sorting the initial inputs. Previously, reopening
97.5, 95, 90…produced97.23, 95.15, 89.53…because lightness was reconstructed from quantized output colors.Motivation
Keep saved input values exact without changing generated colors or the behavior of older URLs. Copy the parsed ratio array before constructing BackgroundColor, which sorts it in place, so unsorted URLs retain the correct lightness/ratio pairing. Invalid saved values fall back to calculated lightness; later ratio edits calculate fresh values normally.
Verified on the production build in Chromium, Firefox and WebKit: repeated round trips, identical output colors, older URLs, reversed stop order, 0/100, invalid/mismatched stop arrays, ratio edits and adding/removing stops. Scoped ESLint and
vite buildpass; existing unused-import and bundle-size warnings are unchanged.To-do list